Code structure/architectur

[gzsombor]

Description

First, thanks for the great project!
I tried to look into the codebase to add Mistral.AI support, but I'm bit confused. It seems that for a lot of provider there are two 'XyzProvider' struct (like two GeminiProvider, OpenAIProvider, etc...). What is the reason behind it? Is it an ongoing refactor to migrate from one setup to another one? Could you share your plan? Currently it's very easy to get lost, what to modify and how.
My other question is that - as I see, Mistral.ai could return a supported list of models, but only if there are an API key, so I could implement fetching the list on demand, so the 'supported' model list shouldn't be fixed at compile time. What do you think? Why this pattern is not used in the other providers?

[vinhnx]

Hi! Thank you for checking out VT Code and for the great questions.

Let me clarify:

There are two systems:

• vtcode-core/src/llm/llm_modular/providers/ - Old/legacy (being phased out)
• vtcode-core/src/llm/providers/ - Current/active (you use this one!)

The duplication is from an ongoing refactor. Focus on the main providers/ directory when adding Mistral.

For adding Mistral.AI, use Z.AI provider as your template (vtcode-core/src/llm/providers/zai.rs) - it's the most similar and recent.

Propose steps:

1. Add constants in vtcode-config/src/constants.rs:

   pub mod mistral {
       pub const DEFAULT_MODEL: &str = "mistral-large-latest";
       pub const SUPPORTED_MODELS: &[&str] = &[... ];
   }

2. Add Provider enum variant in vtcode-config/src/models.rs:

   pub enum Provider {
       // ... existing... 
       Mistral,
   }

3. Create vtcode-core/src/llm/providers/mistral.rs - copy structure from zai.rs, adjust for Mistral's API

4. Register in factory (vtcode-core/src/llm/factory.rs):

   "mistral" => MistralProvider,

5. Export in providers/mod.rs:

   pub use mistral::MistralProvider;

Implementation tip:

Add this to MistralProvider:

pub async fn fetch_available_models(&self) -> Result<Vec<String>, LLMError> {
    let url = format!("{}/models", self.base_url);
    // GET request with API key, parse response
    // Fallback to SUPPORTED_MODELS on error
}

Let me know if you have any issues. Thank you!

[vinhnx]

I will close this issue for now, feel free to reopen if you need help. Thank you!