Skip to content

Commit fa3e209

Browse files
branchseerclaude
andcommitted
fix(test): track dist/output.js and rename glob-base test names
- Force-add dist/output.js which was gitignored but needed for tests - Rename glob-base tests to clarify no special cross-package logic: - 'ignores' -> 'unmatched' to indicate normal glob path matching Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 6fed941 commit fa3e209

File tree

6 files changed

+10
-8
lines changed

6 files changed

+10
-8
lines changed

crates/vite_task_bin/tests/e2e_snapshots/fixtures/glob-base-test/snapshots.toml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Test glob base directory behavior
22
# Globs are relative to PACKAGE directory, NOT task cwd
3+
# No special cross-package filtering - just normal relative path matching
34

45
# 1. Root package - glob matches files in root's src/
56
[[e2e]]
@@ -13,7 +14,7 @@ steps = [
1314
]
1415

1516
[[e2e]]
16-
name = "root glob - ignores other directory"
17+
name = "root glob - unmatched directory"
1718
steps = [
1819
"vite run root-glob-test",
1920
# Modify file outside glob pattern
@@ -23,12 +24,12 @@ steps = [
2324
]
2425

2526
[[e2e]]
26-
name = "root glob - ignores subpackage files"
27+
name = "root glob - subpackage path unmatched by relative glob"
2728
steps = [
2829
"vite run root-glob-test",
29-
# Modify file in subpackage - should NOT match root's src/**
30+
# Modify file in subpackage - relative glob src/** doesn't reach packages/sub-pkg/src/
3031
"replace-file-content packages/sub-pkg/src/sub.ts initial modified",
31-
# Cache hit: subpackage files don't match root's glob
32+
# Cache hit: path simply doesn't match the relative glob pattern
3233
"vite run root-glob-test",
3334
]
3435

@@ -55,7 +56,7 @@ steps = [
5556
]
5657

5758
[[e2e]]
58-
name = "subpackage glob - ignores other directory in subpackage"
59+
name = "subpackage glob - unmatched directory in subpackage"
5960
steps = [
6061
"vite run sub-pkg#sub-glob-test",
6162
# Modify file outside glob pattern
@@ -65,12 +66,12 @@ steps = [
6566
]
6667

6768
[[e2e]]
68-
name = "subpackage glob - ignores root src files"
69+
name = "subpackage glob - root path unmatched by relative glob"
6970
steps = [
7071
"vite run sub-pkg#sub-glob-test",
71-
# Modify file in root - should NOT match subpackage's src/**
72+
# Modify file in root - relative glob src/** is resolved from subpackage dir
7273
"replace-file-content src/root.ts initial modified",
73-
# Cache hit: root files don't match subpackage's glob
74+
# Cache hit: path simply doesn't match the relative glob pattern
7475
"vite run sub-pkg#sub-glob-test",
7576
]
7677

crates/vite_task_bin/tests/e2e_snapshots/fixtures/glob-base-test/snapshots/root glob - ignores subpackage files.snap renamed to crates/vite_task_bin/tests/e2e_snapshots/fixtures/glob-base-test/snapshots/root glob - subpackage path unmatched by relative glob.snap

File renamed without changes.

crates/vite_task_bin/tests/e2e_snapshots/fixtures/glob-base-test/snapshots/root glob - ignores other directory.snap renamed to crates/vite_task_bin/tests/e2e_snapshots/fixtures/glob-base-test/snapshots/root glob - unmatched directory.snap

File renamed without changes.

crates/vite_task_bin/tests/e2e_snapshots/fixtures/glob-base-test/snapshots/subpackage glob - ignores root src files.snap renamed to crates/vite_task_bin/tests/e2e_snapshots/fixtures/glob-base-test/snapshots/subpackage glob - root path unmatched by relative glob.snap

File renamed without changes.

crates/vite_task_bin/tests/e2e_snapshots/fixtures/glob-base-test/snapshots/subpackage glob - ignores other directory in subpackage.snap renamed to crates/vite_task_bin/tests/e2e_snapshots/fixtures/glob-base-test/snapshots/subpackage glob - unmatched directory in subpackage.snap

File renamed without changes.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
// initial output

0 commit comments

Comments
 (0)