feat: exit 0 on --filter no-match, add --fail-if-no-match#393
Merged
Conversation
branchseer
reviewed
May 21, 2026
Member
There was a problem hiding this comment.
Could you also add tests validating behaviors of nested vt run --filter ...?
For example, with scripts:
"filter-nonexistent": "vt run --filter nonexistent build""filter-nonexistent-strict": "vt run --filter nonexistent --fail-if-no-match build"
vt run filter-nonexistent should not fail while vt run filter-nonexistent-strict should.
Contributor
Author
There was a problem hiding this comment.
sorry, lately my commits.
I've just added these!
Resolve conflict in crates/vite_task_plan/src/plan.rs by adopting main's new command_item_index/and_item_index cache-key fields and indentation while preserving this PR's nested_plan rename and no_packages_matched short-circuit in the Query arm. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp run --filter <expr>now exits 0 with a warning when the expression matches no packages, instead of failing withTask "X" not found.--filter {.}^...on a leaf package: the seed matches but the traversal collapses to zero, a legitimate no-op rather than a typo.--fail-if-no-matchfor callers (CI scripts) that want the previous strict behaviour. In strict mode, any unmatched--filteraborts the run, even when other filters did match.Implementation notes
unmatched_selectorsnow tracks filters whose expanded set is empty (was: whose core selector matched nothing), so traversal collapses are reported too.TaskQueryResultexposesselected_package_countandplan_queryreturns aPlanResult { graph, no_packages_matched }so the CLI can distinguish "no packages matched filter" (succeed) from "packages matched but task missing" (still errors asNoTasksMatched).vp run --filter X buildinside a task script gets the same default-success treatment.Closes #380