From 62b14af5c9de1bbec09057971a6f3ad58d4b9393 Mon Sep 17 00:00:00 2001 From: Nicholas Gates Date: Thu, 11 Dec 2025 11:50:37 +0000 Subject: [PATCH 1/6] Run operators benchmarks Signed-off-by: Nicholas Gates --- .github/workflows/bench-pr.yml | 9 +++++---- .github/workflows/ci.yml | 6 +----- .github/workflows/docs.yml | 5 +---- .github/workflows/reuse.yml | 5 +---- 4 files changed, 8 insertions(+), 17 deletions(-) diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml index e94178399eb..227a99b4a3d 100644 --- a/.github/workflows/bench-pr.yml +++ b/.github/workflows/bench-pr.yml @@ -9,10 +9,11 @@ concurrency: cancel-in-progress: false on: - pull_request: - types: [labeled, synchronize] - branches: ["develop"] - workflow_dispatch: { } + push: + branches: ["operators-bench"] + +env: + VORTEX_OPERATORS: "true" permissions: actions: write # for removing labels diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3ca03b48d9c..8cd56a0d3c2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,11 +8,7 @@ name: CI concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: ${{ github.ref != 'refs/heads/develop' }} -on: - push: - branches: [develop] - pull_request: { } - workflow_dispatch: { } +on: { } permissions: actions: read diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 9a913b7fc86..4df02fe8db1 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -4,10 +4,7 @@ concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} cancel-in-progress: true -on: - push: - branches: [develop] - workflow_dispatch: { } +on: { } permissions: contents: read diff --git a/.github/workflows/reuse.yml b/.github/workflows/reuse.yml index e2891f48165..1dd1643418e 100644 --- a/.github/workflows/reuse.yml +++ b/.github/workflows/reuse.yml @@ -7,10 +7,7 @@ concurrency: # Cancel outdated runs on PRs, but let all develop commits complete. cancel-in-progress: ${{ github.ref != 'refs/heads/develop' }} -on: - push: - branches: [develop] - pull_request: { } +on: { } jobs: reuse-check: From c88a717d630e727178d3ccfa75dc34cd338c8056 Mon Sep 17 00:00:00 2001 From: Nicholas Gates Date: Thu, 11 Dec 2025 11:53:16 +0000 Subject: [PATCH 2/6] Run operators benchmarks Signed-off-by: Nicholas Gates --- .github/workflows/bench-pr.yml | 2 -- .github/workflows/labels.yml | 5 +---- .github/workflows/typos.yml | 2 +- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml index 227a99b4a3d..0430dd9ad3c 100644 --- a/.github/workflows/bench-pr.yml +++ b/.github/workflows/bench-pr.yml @@ -34,7 +34,6 @@ jobs: labels: benchmark bench: - needs: label_trigger timeout-minutes: 120 runs-on: - runs-on=${{ github.run_id }} @@ -135,7 +134,6 @@ jobs: comment-tag: bench-pr-comment-${{ matrix.benchmark.id }} sql: - needs: label_trigger uses: ./.github/workflows/sql-benchmarks.yml secrets: inherit with: diff --git a/.github/workflows/labels.yml b/.github/workflows/labels.yml index 27831333caa..bc7d4a39494 100644 --- a/.github/workflows/labels.yml +++ b/.github/workflows/labels.yml @@ -4,10 +4,7 @@ concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} cancel-in-progress: true -on: - pull_request: - # Trigger on these PR activities - types: [opened, reopened, synchronize, labeled, unlabeled] +on: { } jobs: check_changelog_label: diff --git a/.github/workflows/typos.yml b/.github/workflows/typos.yml index e1ca3ab2542..4f0d5fc4969 100644 --- a/.github/workflows/typos.yml +++ b/.github/workflows/typos.yml @@ -7,7 +7,7 @@ concurrency: permissions: contents: read -on: [pull_request] +on: { } env: CLICOLOR: 1 From 3e1d8437f0d63eb58e3a8ee8cf102d9c882096f7 Mon Sep 17 00:00:00 2001 From: Nicholas Gates Date: Thu, 11 Dec 2025 12:32:35 +0000 Subject: [PATCH 3/6] Run operators benchmarks Signed-off-by: Nicholas Gates --- .github/workflows/bench-pr.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml index 0430dd9ad3c..0f5cc4a232c 100644 --- a/.github/workflows/bench-pr.yml +++ b/.github/workflows/bench-pr.yml @@ -9,8 +9,10 @@ concurrency: cancel-in-progress: false on: - push: - branches: ["operators-bench"] + pull_request: + types: [labeled, synchronize] + branches: ["develop"] + workflow_dispatch: { } env: VORTEX_OPERATORS: "true" From b6bacda06d98011238db78000d6f20346e4c444e Mon Sep 17 00:00:00 2001 From: Nicholas Gates Date: Thu, 11 Dec 2025 12:33:29 +0000 Subject: [PATCH 4/6] Run operators benchmarks Signed-off-by: Nicholas Gates --- .github/workflows/bench-pr.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml index 0f5cc4a232c..4e140507ffe 100644 --- a/.github/workflows/bench-pr.yml +++ b/.github/workflows/bench-pr.yml @@ -51,7 +51,6 @@ jobs: name: Random Access - id: compress name: Compression - if: ${{ contains(github.event.head_commit.message, '[benchmark]') || github.event.label.name == 'benchmark' && github.event_name == 'pull_request' }} steps: - uses: runs-on/action@v2 if: github.event.pull_request.head.repo.fork == false From b83213b229febec238c2032b469251f5b9f40e71 Mon Sep 17 00:00:00 2001 From: Nicholas Gates Date: Thu, 11 Dec 2025 13:19:18 +0000 Subject: [PATCH 5/6] Run operators benchmarks Signed-off-by: Nicholas Gates --- .github/workflows/bench-pr.yml | 2 ++ .github/workflows/sql-benchmarks.yml | 6 +++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/bench-pr.yml b/.github/workflows/bench-pr.yml index 4e140507ffe..659fbb9bfaa 100644 --- a/.github/workflows/bench-pr.yml +++ b/.github/workflows/bench-pr.yml @@ -51,6 +51,8 @@ jobs: name: Random Access - id: compress name: Compression + env: + VORTEX_OPERATORS: "true" steps: - uses: runs-on/action@v2 if: github.event.pull_request.head.repo.fork == false diff --git a/.github/workflows/sql-benchmarks.yml b/.github/workflows/sql-benchmarks.yml index 949075339ef..a2087bac69d 100644 --- a/.github/workflows/sql-benchmarks.yml +++ b/.github/workflows/sql-benchmarks.yml @@ -1,5 +1,8 @@ name: "SQL-related benchmarks" +env: + VORTEX_OPERATORS: "true" + on: workflow_call: inputs: @@ -110,7 +113,8 @@ jobs: fail-fast: false matrix: include: ${{ fromJSON(inputs.benchmark_matrix) }} - + env: + VORTEX_OPERATORS: "true" runs-on: - runs-on=${{ github.run_id }} - family=${{ inputs.machine_type }} From b753bfc27e09edd298c876201e631dfa0b3eaa5f Mon Sep 17 00:00:00 2001 From: Nicholas Gates Date: Thu, 11 Dec 2025 14:21:29 +0000 Subject: [PATCH 6/6] Filter runend kernel Signed-off-by: Nicholas Gates --- .github/workflows/sql-benchmarks.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/sql-benchmarks.yml b/.github/workflows/sql-benchmarks.yml index a2087bac69d..3d4dbc3fca4 100644 --- a/.github/workflows/sql-benchmarks.yml +++ b/.github/workflows/sql-benchmarks.yml @@ -155,6 +155,7 @@ jobs: shell: bash env: RUST_BACKTRACE: full + VORTEX_OPERATORS: "true" run: | # Generate data, running each query once to make sure they don't panic. target/release_debug/query_bench \ @@ -198,6 +199,7 @@ jobs: OTEL_EXPORTER_OTLP_ENDPOINT: "${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && secrets.OTEL_EXPORTER_OTLP_ENDPOINT || '' }}" OTEL_EXPORTER_OTLP_HEADERS: "${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && secrets.OTEL_EXPORTER_OTLP_HEADERS || '' }}" OTEL_RESOURCE_ATTRIBUTES: "bench-name=${{ matrix.id }}" + VORTEX_OPERATORS: "true" run: | target/release_debug/query_bench ${{ matrix.subcommand }} \ -d gh-json \ @@ -216,6 +218,7 @@ jobs: OTEL_EXPORTER_OTLP_ENDPOINT: "${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && secrets.OTEL_EXPORTER_OTLP_ENDPOINT || '' }}" OTEL_EXPORTER_OTLP_HEADERS: "${{ (inputs.mode != 'pr' || github.event.pull_request.head.repo.fork == false) && secrets.OTEL_EXPORTER_OTLP_HEADERS || '' }}" OTEL_RESOURCE_ATTRIBUTES: "bench-name=${{ matrix.id }}" + VORTEX_OPERATORS: "true" run: | target/release_debug/query_bench ${{ matrix.subcommand }} \ --use-remote-data-dir ${{ matrix.remote_storage }} \