-
-
Notifications
You must be signed in to change notification settings - Fork 9k
feat(types): enhanced defineComponent inference #12935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: minor
Are you sure you want to change the base?
Conversation
This reverts commit 8bd560d.
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
Sorry to bother but will this be added to 3.6? |
| : T['props'] | ||
| : {} | ||
| > & | ||
| T['__typeProps'] & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| T['__typeProps'] & | |
| IfAny<T['__typeProps'], {}, T['__typeProps']> & |
|
Minimal repro of the latest ci error. |
This PR is all about improving the implementations of
defineComponenttype inference. It's not a complete rewrite because we can't aggressively rewrite or remove existing types/interfaces to maintain backward compatibility (if we have plans for Vue 4 we can revisit that.)Improvements / Changes
emits: {}is now correctly handled as an empty event set