From 10b066633152b149273cfee26570f31bb6e5440b Mon Sep 17 00:00:00 2001 From: Evan Simkowitz Date: Thu, 20 Feb 2025 16:52:09 -0800 Subject: [PATCH] Skip empty XDG values in shellexec --- pkg/shellexec/shellexec.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/shellexec/shellexec.go b/pkg/shellexec/shellexec.go index 93c866126c..26db22500e 100644 --- a/pkg/shellexec/shellexec.go +++ b/pkg/shellexec/shellexec.go @@ -534,7 +534,7 @@ func StartLocalShellProc(logCtx context.Context, termSize waveobj.TermSize, cmdS if len(pamEnvs) > 0 { // We only want to set the XDG variables from the PAM environment, all others should already be correct or may have been overridden by something else out of our control for k := range pamEnvs { - if _, ok := varsToReplace[k]; ok { + if _, ok := varsToReplace[k]; ok && len(pamEnvs[k]) > 0 { varsToReplace[k] = pamEnvs[k] } }