Support multiple labels #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reillyeon
suggested changes
Dec 4, 2025
|
|
||
| `type` only exists when the proofreader object is configured with `includeCorrectionTypes = true`, while `explanation` only exists when the proofreader object is configured with `includeCorrectionExplanations = true`. | ||
|
|
||
| Each correction could be associated with mutliple correction type labels. For example: |
Member
There was a problem hiding this comment.
Suggested change
| Each correction could be associated with mutliple correction type labels. For example: | |
| Each correction could be associated with multiple correction type labels. For example: |
| const original_text = "`thatd` a good amt of time!!! !" // `thatd` is the text to be corrected | ||
| const proofread_text = "`That's` a good amount of time!" // `That's` is the corrected text | ||
| ``` | ||
| where the correction from "thatd" to "That's" contains three types of correction - "Captilization", "Spelling" and "Punctuation". When there's only one label, the sequence will be of size 1. |
Member
There was a problem hiding this comment.
Suggested change
| where the correction from "thatd" to "That's" contains three types of correction - "Captilization", "Spelling" and "Punctuation". When there's only one label, the sequence will be of size 1. | |
| where the correction from "thatd" to "That's" contains three types of correction - "Capitalization", "Spelling" and "Punctuation". When there's only one label, the sequence will be of size 1. |
| unsigned long long endIndex; | ||
| DOMString correction; | ||
| CorrectionType type; // exists if proofreader.includeCorrectionTypes === true | ||
| sequence<CorrectionType> type; // exists if proofreader.includeCorrectionTypes === true |
Member
There was a problem hiding this comment.
Update the "Full API surface in Web IDL" section below as well.
Member
|
@anssiko, can you add discussion of this PR to the next F2F agenda? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the API shape to support multiple labels per correction.
Please see the open issue for detailed discussion: #30