Skip to content

Commit c09be4f

Browse files
committed
Lint formatter fixes
1 parent 284ebd0 commit c09be4f

7 files changed

Lines changed: 24 additions & 6 deletions

File tree

SESSION.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,23 @@
11
# Session Restore Point
22

3+
## 2026-04-29 End Of Day
4+
5+
- WP4 entity extraction is implemented end-to-end.
6+
- Backend added `EntityMention` and `EntityCandidate`, migration `core/migrations/0006_entitycandidate_entitymention.py`, new `core/entity_extraction.py`, and an `extract_entities` pipeline node between classification and relevance.
7+
- Admin now supports reviewing entity candidates and mentions; candidate accept/reject/merge actions are wired in `core/admin.py`.
8+
- API/frontend work is in place for entity mention summaries, project-scoped entity candidate review actions, and the new entity detail page at `frontend/src/app/entities/[id]/page.tsx`.
9+
- `/entities` now shows pending candidates plus recent mention summaries, and links into the entity detail page.
10+
- Focused validation that passed today:
11+
- `pytest core/tests/test_pipeline.py core/tests/test_admin.py -q`
12+
- `pytest core/tests/test_api.py -q`
13+
- `python manage.py check`
14+
- `python manage.py makemigrations --check --dry-run`
15+
- `python3 -m mypy core/pipeline.py core/entity_extraction.py core/embeddings.py core/models.py core/admin.py core/tests/test_pipeline.py core/tests/test_admin.py`
16+
- `cd frontend && npm run typecheck`
17+
- `cd frontend && npm run lint`
18+
- `cd frontend && npx vitest run src/app/entities/__tests__/page.test.tsx src/app/api/entity-candidates/[id]/__tests__/route.test.ts src/app/entities/[id]/__tests__/page.test.tsx`
19+
- Repo-wide `just lint` was rerun after fixing `frontend/src/lib/api.ts` import ordering; backend lint fully passed and direct frontend lint now passes with `FRONTEND_LINT_OK`.
20+
321

422

523
## Useful Commands From Today

core/entity_extraction.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -732,4 +732,4 @@ def _clean_candidate_name(value: str) -> str:
732732
def _normalize_name(value: str) -> str:
733733
"""Case-fold and collapse whitespace for entity-name comparisons."""
734734

735-
return re.sub(r"\s+", " ", value).strip().casefold()
735+
return re.sub(r"\s+", " ", value).strip().casefold()

frontend/src/app/api/entity-candidates/[id]/__tests__/route.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,4 +143,4 @@ describe("POST /api/entity-candidates/[id]", () => {
143143
"http://localhost/entities?error=Unable+to+update+entity+candidate.",
144144
)
145145
})
146-
})
146+
})

frontend/src/app/api/entity-candidates/[id]/route.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,4 +80,4 @@ export async function POST(
8080
buildRedirectUrl(request, redirectTo, { error: message }),
8181
)
8282
}
83-
}
83+
}

frontend/src/app/entities/[id]/__tests__/page.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,4 +236,4 @@ describe("EntityDetailPage", () => {
236236
screen.getByText("No extracted mentions exist for this entity yet."),
237237
).toBeInTheDocument()
238238
})
239-
})
239+
})

frontend/src/app/entities/[id]/page.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,4 +240,4 @@ export default async function EntityDetailPage({
240240
</section>
241241
</AppShell>
242242
)
243-
}
243+
}

skills/entity_extraction/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ Extract tracked-entity mentions from newsletter content and propose new entity c
1313
- Return unknown people, vendors, or organizations in `candidate_entities` as objects with `name` and `suggested_type`.
1414
- `suggested_type` must be one of `individual`, `vendor`, or `organization`.
1515

16-
Return structured JSON only.
16+
Return structured JSON only.

0 commit comments

Comments
 (0)