style fixes

Author: webstackdev

.env.example

@@ -76,12 +76,13 @@ DJANGO_SUPERUSER_USERNAME=admin
 DJANGO_SUPERUSER_EMAIL=admin@example.com
 DJANGO_SUPERUSER_PASSWORD=adminpass
 
-NEWSLETTER_API_BASE_URL=http://nginx
+NEWSLETTER_API_INTERNAL_URL=http://127.0.0.1:8080
+NEWSLETTER_PUBLIC_URL=http://127.0.0.1:8080
 NEWSLETTER_API_USERNAME=admin
 NEWSLETTER_API_PASSWORD=adminpass
 
 DEBUG=True
 
-ALLOWED_HOSTS=localhost,127.0.0.1,newslettermaker.tech
+ALLOWED_HOSTS=localhost,127.0.0.1,nginx,newslettermaker.tech
 
 FRONTEND_URL=http://localhost:3000

.env.test

@@ -8,3 +8,6 @@ REDDIT_CLIENT_SECRET=secret
 REDDIT_USER_AGENT=newsletter-maker/test
 CELERY_BROKER_URL=memory://
 CELERY_RESULT_BACKEND=cache+memory://
+ALLOWED_HOSTS=localhost,127.0.0.1,nginx,testserver
+NEWSLETTER_API_INTERNAL_URL=http://127.0.0.1:8080
+NEWSLETTER_PUBLIC_URL=http://127.0.0.1:8080

README.md

@@ -85,7 +85,7 @@ kubectl port-forward svc/newsletter-maker-newsletter-maker-nginx 8080:80
 > Frontend credentials (from seed):
 >
 > Username: demo_editor
-> Password: demo_password
+> Password: demo-password
 
 **Command Summary:**
 

core/settings_types.py

@@ -11,6 +11,8 @@ class CoreSettings(Protocol):
     LINKEDIN_OAUTH_SCOPES: str
     METRICS_TOKEN: str
     NEWSLETTER_API_BASE_URL: str
+    NEWSLETTER_API_INTERNAL_URL: str
+    NEWSLETTER_PUBLIC_URL: str
     QDRANT_URL: str
     EMBEDDING_MODEL: str
     EMBEDDING_PROVIDER: str

deploy/helm/newsletter-maker/templates/configmap.yaml

@@ -13,7 +13,7 @@ data:
   CHANNEL_LAYER_URL: {{ default (include "newsletter-maker.redisUrl" .) .Values.env.channelLayerUrl | quote }}
   QDRANT_URL: {{ include "newsletter-maker.qdrantUrl" . | quote }}
   MESSAGING_ENABLED: {{ .Values.env.messagingEnabled | quote }}
-  NEWSLETTER_API_BASE_URL: {{ .Values.env.newsletterApiBaseUrl | quote }}
+  NEWSLETTER_PUBLIC_URL: {{ .Values.env.newsletterPublicUrl | quote }}
   EMAIL_BACKEND: {{ .Values.env.emailBackend | quote }}
   DEFAULT_FROM_EMAIL: {{ .Values.env.defaultFromEmail | quote }}
   SERVER_EMAIL: {{ .Values.env.serverEmail | quote }}

deploy/helm/newsletter-maker/values-minikube.yaml

@@ -7,7 +7,7 @@ env:
   debug: "true"
   allowedHosts: "localhost,127.0.0.1,newsletter-maker.local"
   csrfTrustedOrigins: "http://localhost,http://127.0.0.1,http://newsletter-maker.local"
-  newsletterApiBaseUrl: "http://newsletter-maker.local"
+  newsletterPublicUrl: "http://newsletter-maker.local"
 
 nginx:
   service:

deploy/helm/newsletter-maker/values-staging.yaml

@@ -8,7 +8,7 @@ env:
   allowedHosts: "staging.newsletter-maker.example.com"
   csrfTrustedOrigins: "https://staging.newsletter-maker.example.com"
   messagingEnabled: "true"
-  newsletterApiBaseUrl: "https://staging.newsletter-maker.example.com"
+  newsletterPublicUrl: "https://staging.newsletter-maker.example.com"
   logLevel: INFO
 
 secrets:

deploy/helm/newsletter-maker/values.yaml

@@ -13,7 +13,7 @@ env:
   siteId: "1"
   channelLayerUrl: ""
   messagingEnabled: "true"
-  newsletterApiBaseUrl: "http://newsletter-maker.local"
+  newsletterPublicUrl: "http://newsletter-maker.local"
   emailBackend: anymail.backends.resend.EmailBackend
   defaultFromEmail: onboarding@resend.dev
   serverEmail: onboarding@resend.dev

docker-compose.yml

@@ -139,7 +139,7 @@ services:
     env_file:
       - .env
     environment:
-      NEWSLETTER_API_BASE_URL: http://nginx
+      NEWSLETTER_API_INTERNAL_URL: http://nginx
       NEXT_TELEMETRY_DISABLED: "1"
     depends_on:
       nginx:

docs/admin-guide/configuration.md

@@ -3,29 +3,45 @@
 See the [Tunables Reference](../reference/tunables.md) for the exact list of algorithms and thresholds.
 
 ## Required vs Optional Variables
-**Required**: 
-* `DATABASE_URL`, `REDIS_URL`, `QDRANT_URL`, `SECRET_KEY`, `NEWSLETTER_API_BASE_URL`.
+
+**Required**:
+
+* `DATABASE_URL`, `REDIS_URL`, `QDRANT_URL`, `SECRET_KEY`, `NEWSLETTER_PUBLIC_URL`.
+
 **Optional but critical for AI**:
+
 * `OPENROUTER_API_KEY` (Required for relevance tie-breaking and categorization).
 
 ## Secrets Handling
+
 * In Docker Compose: Loaded tightly from the `.env` file mapped securely to the container.
 * In Kubernetes: Expected to be mapped into the Pod `env` spec via Secrets.
 
 ## Internal vs Public URLs
+
 Due to container networking:
-* `NEWSLETTER_API_BASE_URL` (Internal) will reference inner hostnames like `http://nginx`.
+
+* `NEWSLETTER_API_INTERNAL_URL` (Internal) should reference inner hostnames like `http://nginx` when the frontend talks to the backend over a private Docker or Kubernetes network.
 * `NEWSLETTER_PUBLIC_URL` (Public) should point to your real FQDN (e.g. `https://news.mydomain.com`) used in emails.
 
+For local Docker Compose development, the default split is usually:
+
+* `NEWSLETTER_API_INTERNAL_URL=http://nginx`
+* `NEWSLETTER_PUBLIC_URL=http://127.0.0.1:8080`
+
 ## Email Provider (Anymail)
+
 Newsletter intake relies on Resend webhooks and Django Anymail forwarding.
 Configured via:
+
 * `RESEND_API_KEY`
 * `RESEND_INBOUND_SECRET`
 * `DEFAULT_FROM_EMAIL`
 
 ## LLM Provider Routing
+
 Select between `local`, `ollama` or remote providers using `EMBEDDING_PROVIDER`. Set URLs correctly to point to either the internal container (`http://ollama:11434`) or external APIs (`https://api.openai.com/v1`).
 
 ## OAuth Provider Toggles
+
 If `LINKEDIN_CLIENT_ID` or `REDDIT_CLIENT_ID` are present, their respective capabilities light up dynamically in the application.