From 9909e42e3fd6c3d533f6e57f0a4b8b11f7bcfe2c Mon Sep 17 00:00:00 2001 From: Ernesto Tagwerker Date: Thu, 6 Mar 2025 16:34:02 -0500 Subject: [PATCH 1/6] continue-on-error for ruby-head --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d5725091..0f8dcb2f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -127,6 +127,7 @@ jobs: include: - ruby-version: 'ruby-head' experimental: true + continue-on-error: true - ruby-version: 'jruby-9.4' experimental: true From dead51b5866657ed835f0649d1354a674df618f5 Mon Sep 17 00:00:00 2001 From: Ernesto Tagwerker Date: Thu, 6 Mar 2025 16:34:19 -0500 Subject: [PATCH 2/6] add platform value to the gemspec --- rubycritic.gemspec | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/rubycritic.gemspec b/rubycritic.gemspec index 620569cd..ad6f762e 100644 --- a/rubycritic.gemspec +++ b/rubycritic.gemspec @@ -7,6 +7,11 @@ require 'rubycritic/version' Gem::Specification.new do |spec| spec.name = 'rubycritic' spec.version = RubyCritic::VERSION + if RUBY_PLATFORM == 'java' + spec.platform = Gem::Platform::JAVA + else + spec.platform = Gem::Platform::RUBY + end spec.authors = ['Guilherme Simoes'] spec.email = ['guilherme.rdems@gmail.com'] spec.description = 'RubyCritic is a tool that wraps around various static analysis gems ' \ @@ -46,6 +51,7 @@ Gem::Specification.new do |spec| spec.add_development_dependency 'bundler', '>= 2.0.0' if RUBY_PLATFORM == 'java' spec.add_development_dependency 'pry-debugger-jruby' + spec.add_development_dependency 'jar-dependencies', '~> 0.4.1' else spec.add_development_dependency 'byebug', '~> 11.0', '>= 10.0' end From ee831d5debc24d3ad697826d176215532ede11ee Mon Sep 17 00:00:00 2001 From: Ernesto Tagwerker Date: Thu, 6 Mar 2025 16:38:52 -0500 Subject: [PATCH 3/6] Fix rubocop offense --- rubycritic.gemspec | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/rubycritic.gemspec b/rubycritic.gemspec index ad6f762e..536abd37 100644 --- a/rubycritic.gemspec +++ b/rubycritic.gemspec @@ -7,11 +7,7 @@ require 'rubycritic/version' Gem::Specification.new do |spec| spec.name = 'rubycritic' spec.version = RubyCritic::VERSION - if RUBY_PLATFORM == 'java' - spec.platform = Gem::Platform::JAVA - else - spec.platform = Gem::Platform::RUBY - end + spec.platform = RUBY_PLATFORM == 'java' ? Gem::Platform::JAVA : Gem::Platform::RUBY spec.authors = ['Guilherme Simoes'] spec.email = ['guilherme.rdems@gmail.com'] spec.description = 'RubyCritic is a tool that wraps around various static analysis gems ' \ @@ -50,8 +46,8 @@ Gem::Specification.new do |spec| spec.add_development_dependency 'aruba', '~> 2.3.0' spec.add_development_dependency 'bundler', '>= 2.0.0' if RUBY_PLATFORM == 'java' - spec.add_development_dependency 'pry-debugger-jruby' spec.add_development_dependency 'jar-dependencies', '~> 0.4.1' + spec.add_development_dependency 'pry-debugger-jruby' else spec.add_development_dependency 'byebug', '~> 11.0', '>= 10.0' end From f3bc167aec9ebfe0798237443aa81073f5608c18 Mon Sep 17 00:00:00 2001 From: Ernesto Tagwerker Date: Thu, 6 Mar 2025 16:45:35 -0500 Subject: [PATCH 4/6] Fix? --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 0f8dcb2f..070a1025 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -37,6 +37,7 @@ jobs: include: - ruby-version: 'ruby-head' experimental: true + continue-on-error: true - ruby-version: 'jruby-9.4' experimental: true steps: From a7461e0aea7ed8fe12b462763b32c10476a4dde6 Mon Sep 17 00:00:00 2001 From: Ernesto Tagwerker Date: Mon, 10 Mar 2025 15:32:29 -0400 Subject: [PATCH 5/6] Bump jar-dependencies version --- rubycritic.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rubycritic.gemspec b/rubycritic.gemspec index 536abd37..37a1a7e4 100644 --- a/rubycritic.gemspec +++ b/rubycritic.gemspec @@ -46,7 +46,7 @@ Gem::Specification.new do |spec| spec.add_development_dependency 'aruba', '~> 2.3.0' spec.add_development_dependency 'bundler', '>= 2.0.0' if RUBY_PLATFORM == 'java' - spec.add_development_dependency 'jar-dependencies', '~> 0.4.1' + spec.add_development_dependency 'jar-dependencies', '~> 0.5.4' spec.add_development_dependency 'pry-debugger-jruby' else spec.add_development_dependency 'byebug', '~> 11.0', '>= 10.0' From 78310f742d1fbe0b29622bc083e9887f7085a8cb Mon Sep 17 00:00:00 2001 From: Ernesto Tagwerker Date: Mon, 10 Mar 2025 15:36:54 -0400 Subject: [PATCH 6/6] Continue on error with ruby-head --- .github/workflows/main.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 070a1025..08d2dd2d 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -68,6 +68,7 @@ jobs: include: - ruby-version: 'ruby-head' experimental: true + continue-on-error: true - ruby-version: 'jruby-9.4' experimental: true steps: @@ -98,6 +99,7 @@ jobs: include: - ruby-version: 'ruby-head' experimental: true + continue-on-error: true - ruby-version: 'jruby-9.4' experimental: true steps: