From 5df6996646f8e1653a2e486bfd3650cfa760cef9 Mon Sep 17 00:00:00 2001 From: pgaucherand Date: Thu, 24 Nov 2022 15:25:47 +0100 Subject: [PATCH] Updated protobuf dependency to be greater than 4.0. Updated protoc version in github action to 3.19 --- .github/workflows/python-package.yml | 2 +- requirements.txt | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index a15c64b..012e6e1 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -39,7 +39,7 @@ jobs: - name: Install Protoc uses: arduino/setup-protoc@v1 with: - version: '3.14.0' + version: '3.19.0' - name: Generate proto files run: | diff --git a/requirements.txt b/requirements.txt index 4aceb89..0bbbcd4 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,3 +1,5 @@ -# 3.12.2 version is used as it is -# the version available in alpine 3.12 (for protobuf cpp version) -protobuf>=3.12.2,<4.0 +# Protobuf version above major version 4 require the file to be compiled with +# protoc 3.19 or newer. +# TODO Alpine image currently support protoc 3.18+, so it is required to wait for an +# alpine image with updated protoc before a new image can be generated +protobuf>=4.0