Make differs/patchers required by MediaInfo public

thiemowmde · thiemowmde · commit 79f19a3cd5aa · 2016-05-09T17:06:46.000+02:00
diff --git a/src/Diff/Internal/FingerprintPatcher.php b/src/Diff/Internal/FingerprintPatcher.php
@@ -4,12 +4,10 @@
 
 use Diff\Patcher\PatcherException;
 use Wikibase\DataModel\Services\Diff\EntityDiff;
+use Wikibase\DataModel\Services\Diff\TermListPatcher;
 use Wikibase\DataModel\Term\Fingerprint;
 
 /**
- * TODO: Class should be public.
- * TODO: Should this support actual edit conflict detection?
- *
  * Package private.
  *
  * @since 1.0
diff --git a/src/Diff/Internal/SiteLinkListPatcher.php b/src/Diff/Internal/SiteLinkListPatcher.php
@@ -10,9 +10,6 @@
 use Wikibase\DataModel\SiteLinkList;
 
 /**
- * TODO: Class should be public.
- * TODO: Should this support actual edit conflict detection?
- *
  * Package private.
  *
  * @license GPL-2.0+
diff --git a/src/Diff/ItemDiffer.php b/src/Diff/ItemDiffer.php
@@ -7,7 +7,6 @@
 use Wikibase\DataModel\Entity\EntityDocument;
 use Wikibase\DataModel\Entity\Item;
 use Wikibase\DataModel\Entity\ItemId;
-use Wikibase\DataModel\Services\Diff\Internal\StatementListDiffer;
 use Wikibase\DataModel\SiteLinkList;
 
 /**
diff --git a/src/Diff/ItemPatcher.php b/src/Diff/ItemPatcher.php
@@ -7,7 +7,6 @@
 use Wikibase\DataModel\Entity\Item;
 use Wikibase\DataModel\Services\Diff\Internal\FingerprintPatcher;
 use Wikibase\DataModel\Services\Diff\Internal\SiteLinkListPatcher;
-use Wikibase\DataModel\Services\Diff\Internal\StatementListPatcher;
 
 /**
  * @since 1.0
@@ -76,10 +75,10 @@ private function patchItem( Item $item, EntityDiff $patch ) {
 			) );
 		}
 
-		$item->setStatements( $this->statementListPatcher->getPatchedStatementList(
+		$this->statementListPatcher->patchStatementList(
 			$item->getStatements(),
 			$patch->getClaimsDiff()
-		) );
+		);
 	}
 
 }
diff --git a/src/Diff/PropertyDiffer.php b/src/Diff/PropertyDiffer.php
@@ -7,7 +7,6 @@
 use InvalidArgumentException;
 use Wikibase\DataModel\Entity\EntityDocument;
 use Wikibase\DataModel\Entity\Property;
-use Wikibase\DataModel\Services\Diff\Internal\StatementListDiffer;
 use Wikibase\DataModel\Statement\StatementList;
 
 /**
diff --git a/src/Diff/PropertyPatcher.php b/src/Diff/PropertyPatcher.php
@@ -6,7 +6,6 @@
 use Wikibase\DataModel\Entity\EntityDocument;
 use Wikibase\DataModel\Entity\Property;
 use Wikibase\DataModel\Services\Diff\Internal\FingerprintPatcher;
-use Wikibase\DataModel\Services\Diff\Internal\StatementListPatcher;
 
 /**
  * @since 1.0
@@ -62,10 +61,10 @@ private function assertIsProperty( EntityDocument $property ) {
 	private function patchProperty( Property $property, EntityDiff $patch ) {
 		$this->fingerprintPatcher->patchFingerprint( $property->getFingerprint(), $patch );
 
-		$property->setStatements( $this->statementListPatcher->getPatchedStatementList(
+		$this->statementListPatcher->patchStatementList(
 			$property->getStatements(),
 			$patch->getClaimsDiff()
-		) );
+		);
 	}
 
 }
diff --git a/src/Diff/StatementListDiffer.php b/src/Diff/StatementListDiffer.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Wikibase\DataModel\Services\Diff\Internal;
+namespace Wikibase\DataModel\Services\Diff;
 
 use Diff\Differ\MapDiffer;
 use Diff\DiffOp\Diff\Diff;
@@ -9,11 +9,7 @@
 use Wikibase\DataModel\Statement\StatementList;
 
 /**
- * TODO: Class must be public.
- *
- * Package private.
- *
- * @since 1.0
+ * @since 3.6
  *
  * @license GPL-2.0+
  * @author Jeroen De Dauw < jeroendedauw@gmail.com >
diff --git a/src/Diff/StatementListPatcher.php b/src/Diff/StatementListPatcher.php
@@ -1,24 +1,18 @@
 <?php
 
-namespace Wikibase\DataModel\Services\Diff\Internal;
+namespace Wikibase\DataModel\Services\Diff;
 
 use Diff\DiffOp\Diff\Diff;
 use Diff\DiffOp\DiffOp;
 use Diff\DiffOp\DiffOpAdd;
 use Diff\DiffOp\DiffOpChange;
 use Diff\DiffOp\DiffOpRemove;
 use Diff\Patcher\PatcherException;
-use InvalidArgumentException;
 use Wikibase\DataModel\Statement\Statement;
 use Wikibase\DataModel\Statement\StatementList;
 
 /**
- * TODO: Class must be public.
- * TODO: Should this support actual edit conflict detection?
- *
- * Package private.
- *
- * @since 1.0
+ * @since 3.6
  *
  * @license GPL-2.0+
  * @author Jeroen De Dauw < jeroendedauw@gmail.com >
@@ -64,19 +58,4 @@ public function patchStatementList( StatementList $statements, Diff $patch ) {
 		}
 	}
 
-	/**
-	 * @deprecated since 3.6, use patchStatementList instead
-	 *
-	 * @param StatementList $statements
-	 * @param Diff $patch
-	 *
-	 * @throws InvalidArgumentException
-	 * @return StatementList
-	 */
-	public function getPatchedStatementList( StatementList $statements, Diff $patch ) {
-		$patched = clone $statements;
-		$this->patchStatementList( $patched, $patch );
-		return $patched;
-	}
-
 }
diff --git a/src/Diff/TermListPatcher.php b/src/Diff/TermListPatcher.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Wikibase\DataModel\Services\Diff\Internal;
+namespace Wikibase\DataModel\Services\Diff;
 
 use Diff\DiffOp\AtomicDiffOp;
 use Diff\DiffOp\Diff\Diff;
@@ -11,8 +11,6 @@
 use Wikibase\DataModel\Term\TermList;
 
 /**
- * Package private.
- *
  * @since 3.6
  *
  * @license GPL-2.0+
diff --git a/tests/unit/Diff/EntityDiffTest.php b/tests/unit/Diff/EntityDiffTest.php
@@ -8,7 +8,7 @@
 use Diff\DiffOp\DiffOpRemove;
 use PHPUnit_Framework_TestCase;
 use Wikibase\DataModel\Services\Diff\EntityDiff;
-use Wikibase\DataModel\Services\Diff\Internal\StatementListDiffer;
+use Wikibase\DataModel\Services\Diff\StatementListDiffer;
 use Wikibase\DataModel\Snak\PropertyNoValueSnak;
 use Wikibase\DataModel\Statement\Statement;
 use Wikibase\DataModel\Statement\StatementList;
diff --git a/tests/unit/Diff/StatementListDifferTest.php b/tests/unit/Diff/StatementListDifferTest.php
@@ -1,19 +1,19 @@
 <?php
 
-namespace Wikibase\DataModel\Services\Tests\Diff\Internal;
+namespace Wikibase\DataModel\Services\Tests\Diff;
 
 use DataValues\StringValue;
 use Diff\DiffOp\Diff\Diff;
 use Diff\DiffOp\DiffOpAdd;
 use Diff\DiffOp\DiffOpChange;
 use Diff\DiffOp\DiffOpRemove;
-use Wikibase\DataModel\Services\Diff\Internal\StatementListDiffer;
+use Wikibase\DataModel\Services\Diff\StatementListDiffer;
 use Wikibase\DataModel\Snak\PropertyValueSnak;
 use Wikibase\DataModel\Statement\Statement;
 use Wikibase\DataModel\Statement\StatementList;
 
 /**
- * @covers Wikibase\DataModel\Services\Diff\Internal\StatementListDiffer
+ * @covers Wikibase\DataModel\Services\Diff\StatementListDiffer
  *
  * @license GPL-2.0+
  * @author Jeroen De Dauw < jeroendedauw@gmail.com >
diff --git a/tests/unit/Diff/StatementListPatcherTest.php b/tests/unit/Diff/StatementListPatcherTest.php
@@ -1,21 +1,21 @@
 <?php
 
-namespace Wikibase\DataModel\Services\Tests\Diff\Internal;
+namespace Wikibase\DataModel\Services\Tests\Diff;
 
 use DataValues\StringValue;
 use Diff\DiffOp\Diff\Diff;
 use Diff\DiffOp\DiffOpAdd;
 use Diff\DiffOp\DiffOpChange;
 use Diff\DiffOp\DiffOpRemove;
-use Wikibase\DataModel\Services\Diff\Internal\StatementListPatcher;
+use Wikibase\DataModel\Services\Diff\StatementListPatcher;
 use Wikibase\DataModel\Snak\PropertyNoValueSnak;
 use Wikibase\DataModel\Snak\PropertySomeValueSnak;
 use Wikibase\DataModel\Snak\PropertyValueSnak;
 use Wikibase\DataModel\Statement\Statement;
 use Wikibase\DataModel\Statement\StatementList;
 
 /**
- * @covers Wikibase\DataModel\Services\Diff\Internal\StatementListPatcher
+ * @covers Wikibase\DataModel\Services\Diff\StatementListPatcher
  *
  * @license GPL-2.0+
  * @author Jeroen De Dauw < jeroendedauw@gmail.com >
@@ -112,11 +112,14 @@ public function testGivenEmptyDiff_listIsReturnedAsIs() {
 		$this->assertListResultsFromPatch( $statements, $statements, new Diff() );
 	}
 
-	private function assertListResultsFromPatch( StatementList $expected, StatementList $original, Diff $patch ) {
+	private function assertListResultsFromPatch(
+		StatementList $expected,
+		StatementList $statements,
+		Diff $patch
+	) {
 		$patcher = new StatementListPatcher();
-		$clone = clone $original;
-		$this->assertEquals( $expected, $patcher->getPatchedStatementList( $original, $patch ) );
-		$this->assertEquals( $clone, $original, 'original must not change' );
+		$patcher->patchStatementList( $statements, $patch );
+		$this->assertEquals( $expected, $statements );
 	}
 
 	public function testFoo() {
diff --git a/tests/unit/Diff/TermListPatcherTest.php b/tests/unit/Diff/TermListPatcherTest.php
@@ -1,18 +1,18 @@
 <?php
 
-namespace Wikibase\DataModel\Services\Tests\Diff\Internal;
+namespace Wikibase\DataModel\Services\Tests\Diff;
 
 use Diff\DiffOp\Diff\Diff;
 use Diff\DiffOp\DiffOpAdd;
 use Diff\DiffOp\DiffOpChange;
 use Diff\DiffOp\DiffOpRemove;
 use PHPUnit_Framework_TestCase;
-use Wikibase\DataModel\Services\Diff\Internal\TermListPatcher;
+use Wikibase\DataModel\Services\Diff\TermListPatcher;
 use Wikibase\DataModel\Term\Term;
 use Wikibase\DataModel\Term\TermList;
 
 /**
- * @covers Wikibase\DataModel\Services\Diff\Internal\TermListPatcher
+ * @covers Wikibase\DataModel\Services\Diff\TermListPatcher
  *
  * @license GPL-2.0+
  * @author Bene* < benestar.wikimedia@gmail.com >

Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,6 @@`
`10`	`10`	`use Wikibase\DataModel\SiteLinkList;`
`11`	`11`
`12`	`12`	`/**`
`13`		`- * TODO: Class should be public.`
`14`		`- * TODO: Should this support actual edit conflict detection?`
`15`		`- *`
`16`	`13`	`* Package private.`
`17`	`14`	`*`
`18`	`15`	`* @license GPL-2.0+`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,6 @@`
`7`	`7`	`use Wikibase\DataModel\Entity\Item;`
`8`	`8`	`use Wikibase\DataModel\Services\Diff\Internal\FingerprintPatcher;`
`9`	`9`	`use Wikibase\DataModel\Services\Diff\Internal\SiteLinkListPatcher;`
`10`		`-use Wikibase\DataModel\Services\Diff\Internal\StatementListPatcher;`
`11`	`10`
`12`	`11`	`/**`
`13`	`12`	`* @since 1.0`
`@@ -76,10 +75,10 @@ private function patchItem( Item $item, EntityDiff $patch ) {`
`76`	`75`	`) );`
`77`	`76`	`}`
`78`	`77`
`79`		`- $item->setStatements( $this->statementListPatcher->getPatchedStatementList(`
	`78`	`+ $this->statementListPatcher->patchStatementList(`
`80`	`79`	`$item->getStatements(),`
`81`	`80`	`$patch->getClaimsDiff()`
`82`		`- ) );`
	`81`	`+ );`
`83`	`82`	`}`
`84`	`83`
`85`	`84`	`}`