Merge branch 'main' into copilot/add-progress-bar-indicator

Author: swissspidy

.gitattributes

@@ -0,0 +1,14 @@
+/.actrc export-ignore
+/.distignore export-ignore
+/.editorconfig export-ignore
+/.github export-ignore
+/.gitignore export-ignore
+/.typos.toml export-ignore
+/AGENTS.md export-ignore
+/behat.yml export-ignore
+/features export-ignore
+/phpcs.xml.dist export-ignore
+/phpstan.neon.dist export-ignore
+/phpunit.xml.dist export-ignore
+/tests export-ignore
+/wp-cli.yml export-ignore

.github/workflows/copilot-setup-steps.yml

@@ -21,13 +21,11 @@ jobs:
 
       - name: Check existence of composer.json file
         id: check_composer_file
-        uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3
-        with:
-          files: "composer.json"
+        run: echo "files_exists=$(test -f composer.json && echo true || echo false)" >> "$GITHUB_OUTPUT"
 
       - name: Set up PHP environment
         if: steps.check_composer_file.outputs.files_exists == 'true'
-        uses: shivammathur/setup-php@44454db4f0199b8b9685a5d763dc37cbf79108e1 # v2
+        uses: shivammathur/setup-php@accd6127cb78bee3e8082180cb391013d204ef9f # v2
         with:
           php-version: 'latest'
           ini-values: zend.assertions=1, error_reporting=-1, display_errors=On
@@ -38,7 +36,7 @@ jobs:
 
       - name: Install Composer dependencies & cache dependencies
         if: steps.check_composer_file.outputs.files_exists == 'true'
-        uses: ramsey/composer-install@a35c6ebd3d08125aaf8852dff361e686a1a67947 # v3
+        uses: ramsey/composer-install@65e4f84970763564f46a70b8a54b90d033b3bdda # v3
         env:
           COMPOSER_ROOT_VERSION: dev-${{ github.event.repository.default_branch }}
         with:

README.md

@@ -23,6 +23,10 @@ multisite, this will just be the tables for the current site unless
 Search/replace intelligently handles PHP serialized data, and does not
 change primary key values.
 
+Tables without a primary key are skipped. To check whether a table has a
+primary key, run `wp db query 'DESCRIBE <table>'` and look for 'PRI' in
+the Key column.
+
 **OPTIONS**
 
 	[<old>]
@@ -75,11 +79,13 @@ change primary key values.
 
 	[--skip-columns=<columns>]
 		Do not perform the replacement on specific columns. Use commas to
-		specify multiple columns.
+		specify multiple columns. Table-qualified column names ("table.column")
+		are supported to apply the skip to a specific table only.
 
 	[--include-columns=<columns>]
 		Perform the replacement on specific columns. Use commas to
-		specify multiple columns.
+		specify multiple columns. Table-qualified column names ("table.column")
+		are supported to apply the inclusion to a specific table only.
 
 	[--precise]
 		Force the use of PHP (instead of SQL) for all columns. By default, the command
@@ -193,6 +199,10 @@ Want to contribute a new feature? Please first [open a new issue](https://github
 
 Once you've decided to commit the time to seeing your pull request through, [please follow our guidelines for creating a pull request](https://make.wordpress.org/cli/handbook/pull-requests/) to make sure it's a pleasant experience. See "[Setting up](https://make.wordpress.org/cli/handbook/pull-requests/#setting-up)" for details specific to working on this package locally.
 
+### License
+
+This project is licensed under the MIT License. See the [LICENSE](LICENSE) file for details.
+
 ## Support
 
 GitHub issues aren't for general support questions, but there are other venues you can try: https://wp-cli.org/#support

features/search-replace.feature

@@ -41,6 +41,17 @@ Feature: Do global search/replace
       | Table    | Column       | Replacements | Type |
       | wp_posts | post_content | 0            | SQL  |
 
+    When I run `wp search-replace foo bar --skip-columns=wp_posts.guid`
+    Then STDOUT should not contain:
+      """
+      guid
+      """
+
+    When I run `wp search-replace foo bar --include-columns=wp_posts.post_content`
+    Then STDOUT should be a table containing rows:
+      | Table    | Column       | Replacements | Type |
+      | wp_posts | post_content | 0            | SQL  |
+
   @require-mysql
   Scenario: Multisite search/replace
     Given a WP multisite install
@@ -68,6 +79,31 @@ Feature: Do global search/replace
       wp_awesome
       """
 
+  @require-mysql
+  Scenario: Skip views during search/replace
+    Given a WP install
+    And I run `wp db query "CREATE VIEW wp_posts_view AS SELECT ID, post_title FROM wp_posts;"`
+
+    When I run `wp search-replace foo bar --all-tables-with-prefix`
+    Then STDOUT should contain:
+      """
+      wp_posts_view
+      """
+    And STDOUT should contain:
+      """
+      skipped (view)
+      """
+
+    When I run `wp search-replace foo bar --all-tables`
+    Then STDOUT should contain:
+      """
+      wp_posts_view
+      """
+    And STDOUT should contain:
+      """
+      skipped (view)
+      """
+
   @require-mysql
   Scenario: Run on unregistered, unprefixed tables with --all-tables flag
     Given a WP install
@@ -185,6 +221,8 @@ Feature: Do global search/replace
       1 rows affected
       """
 
+  # See https://github.com/wp-cli/search-replace-command/issues/190
+  @skip-sqlite
   Scenario: Regex search/replace
     Given a WP install
     When I run `wp search-replace '(Hello)\s(world)' '$2, $1' --regex`
@@ -238,6 +276,45 @@ Feature: Do global search/replace
       | key               | value                                    |
       | header_image_data | {"url":"https:\/\/example.com\/foo.jpg"} |
 
+  @require-mysql
+  Scenario: Search and replace handles JSON-encoded URLs in post content
+    Given a WP install
+
+    When I run `wp post create --post_content='{"src":"http:\/\/example.com\/wp-content\/uploads\/fonts\/test.woff2","fontWeight":"400"}' --post_status=publish --porcelain`
+    Then save STDOUT as {POST_ID}
+
+    When I run `wp post get {POST_ID} --field=post_content`
+    Then STDOUT should contain:
+      """
+      http:\/\/example.com
+      """
+
+    When I run `wp search-replace 'http://example.com' 'http://newdomain.com' wp_posts --include-columns=post_content`
+    Then STDOUT should be a table containing rows:
+      | Table    | Column       | Replacements | Type |
+      | wp_posts | post_content | 1            | SQL  |
+
+    When I run `wp post get {POST_ID} --field=post_content`
+    Then STDOUT should contain:
+      """
+      http:\/\/newdomain.com
+      """
+    And STDOUT should not contain:
+      """
+      http:\/\/example.com
+      """
+
+    When I run `wp search-replace 'http://newdomain.com' 'http://example.com' wp_posts --include-columns=post_content --precise`
+    Then STDOUT should be a table containing rows:
+      | Table    | Column       | Replacements | Type |
+      | wp_posts | post_content | 1            | PHP  |
+
+    When I run `wp post get {POST_ID} --field=post_content`
+    Then STDOUT should contain:
+      """
+      http:\/\/example.com
+      """
+
   @require-mysql
   Scenario: Search and replace with quoted strings
     Given a WP install
@@ -884,6 +961,8 @@ Feature: Do global search/replace
       """
     And STDERR should be empty
 
+  # See https://github.com/wp-cli/search-replace-command/issues/190
+  @skip-sqlite
   Scenario: Logging with regex replace
     Given a WP install
 
@@ -1246,6 +1325,8 @@ Feature: Do global search/replace
       [field_count] => 2
       """
 
+  # See https://github.com/wp-cli/search-replace-command/issues/190
+  @skip-sqlite
   Scenario: Regex search/replace with `--regex-limit=1` option
     Given a WP install
     And I run `wp post create --post_content="I have a pen, I have an apple. Pen, pine-apple, apple-pen."`
@@ -1256,6 +1337,8 @@ Feature: Do global search/replace
       I have a pen, I have an orange. Pen, pine-apple, apple-pen.
       """
 
+  # See https://github.com/wp-cli/search-replace-command/issues/190
+  @skip-sqlite
   Scenario: Regex search/replace with `--regex-limit=2` option
     Given a WP install
     And I run `wp post create --post_content="I have a pen, I have an apple. Pen, pine-apple, apple-pen."`
@@ -1266,6 +1349,8 @@ Feature: Do global search/replace
       I have a pen, I have an orange. Pen, pine-orange, apple-pen.
       """
 
+  # See https://github.com/wp-cli/search-replace-command/issues/190
+  @skip-sqlite
   Scenario: Regex search/replace with incorrect or default `--regex-limit`
     Given a WP install
     When I try `wp search-replace '(Hello)\s(world)' '$2, $1' --regex --regex-limit=asdf`
@@ -1560,3 +1645,21 @@ Feature: Do global search/replace
       """
       --old-content
       """
+
+
+  @require-mysql
+  Scenario: Warn when updating a table fails due to a database error
+    Given a WP install
+    And I run `wp db query "CREATE TABLE wp_readonly_test ( id int(11) unsigned NOT NULL AUTO_INCREMENT, data TEXT, PRIMARY KEY (id) ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;"`
+    And I run `wp db query "INSERT INTO wp_readonly_test (data) VALUES ('old-value');"`
+    And I run `wp db query "CREATE TRIGGER prevent_update BEFORE UPDATE ON wp_readonly_test FOR EACH ROW SIGNAL SQLSTATE '45000' SET MESSAGE_TEXT = 'Table is read-only';"`
+
+    When I try `wp search-replace old-value new-value --all-tables-with-prefix`
+    Then STDERR should contain:
+      """
+      Error updating column 'data' in table 'wp_readonly_test'
+      """
+    And STDERR should contain:
+      """
+      Table is read-only
+      """