fix: make vulture blocking and add whitelist for Pydantic validators

- Changed vulture from error: true to error: false (blocking check)
- Created .vulture_whitelist.py to whitelist cls parameter in validators
- Updated CI to use whitelist file in vulture command
- Removed temporary noqa comments from models.py
- Vulture will now block CI if dead code is found

Author: tknecht

.github/workflows/ci.yml

@@ -72,8 +72,8 @@ jobs:
             cmd: "pydocstyle xarf/"
             error: true
           - name: "Dead code (vulture)"
-            cmd: "vulture xarf/ --min-confidence 80"
-            error: true
+            cmd: "vulture xarf/ .vulture_whitelist.py --min-confidence 80"
+            error: false
 
     steps:
       - uses: actions/checkout@v4

.vulture_whitelist.py

@@ -0,0 +1,5 @@
+# Vulture whitelist for intentionally unused code
+# https://github.com/jendrikseipp/vulture
+
+# Pydantic validators require 'cls' parameter even if unused
+_.cls  # unused variable (validators)