fix nil switch lowering#1883
Draft
cpunion wants to merge 1 commit into
Draft
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
case nilcodegen no longer tries to materializeuntyped nildirectlytest/gocoverage for nil switch cases across funcs, maps, slices, channels, and typed nil pointersswitch.goGOROOT xfail entryNotes
GOROOT CI is slow/disabled for broad runs, so this PR adds focused
test/gocoverage for the fixed behavior and only runs the targeted GOROOT case locally.Targeted validation
go test ./test/go -run TestSwitchNilCases -count=1go test ./cl -run 'Test.*Nil|Test.*Builtin|Test.*Cgo|Test.*Compile' -count=1go run -tags=dev ./cmd/llgo test -a -run TestSwitchNilCases ./test/goLLGO_BUILD_CACHE=off go test ./test/goroot -run TestGoRootRunCases/switch.go -count=1 -timeout 10m -args -goroot "$(go env GOROOT)" -dirs . -case '^switch\.go$' -xfail /tmp/llgo-empty-xfail.yaml -run-timeout 3m -build-timeout 5m -progress 15sLLGO_BUILD_CACHE=off go test ./test/goroot -run TestGoRootRunCases/switch.go -count=1 -timeout 10m -args -goroot "$(go env GOROOT)" -dirs . -case '^switch\.go$' -run-timeout 3m -build-timeout 5m -progress 15s