runtime: match legacy complex print exponents#1889
Draft
cpunion wants to merge 2 commits into
Draft
Conversation
Collaborator
Author
|
Update for Root cause:
Fix:
Local testing:
|
Collaborator
Author
|
CI update for
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%eexponents to Go's three-digit width so complex print output matches Go 1.24/1.25test/gocoverage for constant, argument, and variable complex builtin printingken/cplx0.goGOROOT xfails for Go 1.24/1.25 on darwin/arm64 and linux/amd64Validation
go test ./test/go -count=1 -run 'TestBuiltinPrintComplexLegacy'\n-go run ./cmd/llgo test -run 'TestBuiltinPrintComplexLegacy' -count=1 test/go/print_builtin_legacy_test.go\n-(cd runtime && go test ./internal/runtime -count=1)\n-go test ./test/goroot -count=1 -run TestGoRootRunCases -args -goroot "$(go env GOROOT)" -dirs ken -case '^ken/cplx0\\.go$' -xfail /tmp/llgo-empty-xfail-numeric.yaml\n\nGOROOT CI is slow/disabled, so this PR relies on targeted GOROOT reproduction plus stabletest/gocoverage. Normal PR CI should run from the fork branch.\n\n## Notes\n- A package-widego run ./cmd/llgo test -run 'TestBuiltinPrintComplexLegacy' -count=1 ./test/goattempt currently links an unrelated existinggeneric_local_types_test.gosymbol failure on this darwin/arm64 machine; the new file-level test above passes.