runtime: short-circuit struct equality before string bodies#1895
Draft
cpunion wants to merge 1 commit into
Draft
runtime: short-circuit struct equality before string bodies#1895cpunion wants to merge 1 commit into
cpunion wants to merge 1 commit into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/gocoverage for protected-string interface struct comparisons and interface panic ordering.fixedbugs/issue8606b.goGOROOT xfail entries.GOROOT CI note
Full GOROOT runs are slow/disabled for this slice. This PR uses targeted
test/gorootruns with the current machine GOROOT (go env GOROOT=/opt/homebrew/Cellar/go@1.24/1.24.11/libexec) and relies on normal PR CI from the fork branch. No branch was pushed toxgo-dev/llgo; if manual GOROOTworkflow_dispatchcannot resolve fork refs, that should be documented rather than pushing toxgo-dev.Test coverage
New stable coverage is in
test/go/interface_string_compare_test.gofor the fixed string/interface comparison behavior.Targeted commands
go test ./test/goroot -run TestGoRootRunCases -count=1 -timeout 10m -args -goroot $(go env GOROOT) -dirs fixedbugs -case "^fixedbugs/issue8606b\.go$" -xfail /tmp/llgo-empty-xfail.yaml -run-timeout 30s(failed: llgo signal exit, go exit 0)go test ./test/go -run "TestInterfaceStruct(StringCompareShortCircuits|ComparePreservesInterfacePanicOrder)" -count=1go run ./cmd/llgo test -run "TestInterfaceStruct(StringCompareShortCircuits|ComparePreservesInterfacePanicOrder)" -count=1 ./test/gogo test ./ssa -run TestBinOp -count=1go test ./cl -run TestDoesNotExist -count=1(cd runtime && go test ./internal/runtime -run TestDoesNotExist -count=1)go test ./test/goroot -run TestGoRootRunCases -count=1 -timeout 10m -args -goroot $(go env GOROOT) -dirs fixedbugs -case "^fixedbugs/issue8606b\.go$" -xfail /tmp/llgo-empty-xfail.yaml -run-timeout 30sgo test ./test/goroot -run TestGoRootRunCases -count=1 -timeout 10m -args -goroot $(go env GOROOT) -dirs fixedbugs -case "^fixedbugs/issue8606b\.go$" -run-timeout 30sResidual risk
Linux GOROOT entries were removed because they are the same runtime equality root cause, but Linux GOROOT was not run locally on this darwin/arm64 host.