reflect: handle empty fields in FFI struct calls#1897
Draft
cpunion wants to merge 1 commit into
Draft
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Focused tests
go test ./test/goroot -run TestGoRootRunCases -count=1 -args -goroot "$(go env GOROOT)" -llgo /tmp/llgo-reflectcall -dirs fixedbugs -case "^fixedbugs/issue26335\.go$" -xfail /tmp/llgo-empty-xfail.yaml -run-timeout 30s -build-timeout 2mgo test ./test/goroot -run TestGoRootRunCases -count=1 -args -goroot "$(go env GOROOT)" -llgo /tmp/llgo-reflectcall -dirs fixedbugs -case "^fixedbugs/issue26335\.go$" -run-timeout 30s -build-timeout 2m/tmp/llgo-reflectcall test -run TestReflectCallStructWithEmptyField ./test/gogo test ./test/go -run TestReflectCallStructWithEmptyField -count=1(cd runtime && go test ./internal/lib/reflect ./internal/ffi -count=1)GOROOT CI
The full GOROOT workflow is workflow_dispatch-only and slow/disabled for normal PR CI. I kept the run targeted locally with the current machine GOROOT (
go env GOROOT=/opt/homebrew/Cellar/go@1.24/1.24.11/libexec). If manual GOROOT dispatch cannot resolve fork refs, this PR should rely on normal PR CI from thecpunion/llgofork branch and keep that blocker documented here rather than pushing any branch toxgo-dev/llgo.Notes
I only removed the darwin/arm64 xfail entry verified locally. Linux version-specific xfails for the same upstream case remain until they can be executed on Linux.