Fix slice-to-array conversion panics#1899
Draft
cpunion wants to merge 2 commits into
Draft
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
Conversion-only update for this draft PR. Changes in
Goroot case status:
Local validation:
PR is still draft. CI has started on the new head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/gocoverage and remove fixedconvert4.gogoroot xfailsTests
go test ./test/go -run 'TestSliceToArrayConversion' -count=1go test ./ssa -count=1go test ./cl -run 'TestRunAndTestFromTestrt|TestSkipUnusedArrayDeref' -count=1(cd runtime && go test ./internal/runtime -count=1)go run ./cmd/llgo test -run 'TestSliceToArrayConversion' ./test/gogo test ./test/goroot -count=1 -run TestGoRootRunCases -args -goroot "$(go env GOROOT)" -dirs . -case '^convert4\.go$' -directive-mode legacy -xfail /tmp/llgo-empty-xfail.yaml -progress 30sgo test ./test/goroot -count=1 -run TestGoRootRunCases -args -goroot "$(go env GOROOT)" -dirs . -case '^convert4\.go$' -directive-mode legacy -progress 30sNotes
$(go env GOROOT)($(go env GOVERSION),$(go env GOOS)/$(go env GOARCH)).convert4.gogoroot run above.test/go/slice_array_convert_test.go, so the fix is not covered only bytest/goroot.