fix bounds panic messages#1901
Draft
cpunion wants to merge 2 commits into
Draft
Conversation
Collaborator
Author
|
PR #1901 follow-up for head b072c41. Root cause: the failing Fix: updated the Local tests run:
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GOROOT note
Full GOROOT CI is slow/disabled locally, so I ran targeted fixedbugs cases only. Machine GOROOT: /opt/homebrew/Cellar/go@1.24/1.24.11/libexec (go1.24.11 darwin/arm64). Normal PR CI should run from the fork branch.
Test/go coverage
Added test/go/bounds_panic_text_test.go covering runtime.Error panic text for signed/unsigned index checks, slice/string/array slicing, len vs capacity wording, and full slice max bounds.
Targeted commands run
go test ./runtime/internal/runtime -count=1is not applicable in this module layout; that runtime path is validated through LLGotest/go, SSA/CL checks, and the targeted GOROOT run.