runtime: add runtime/metrics Read support#1907
Open
zhouguangyuan0718 wants to merge 1 commit into
Open
Conversation
Implement an LLGo source patch for runtime/metrics.Read so standard Go metrics keep their documented ValueKind while unsupported values default to zero. Use runtime.MemStats directly for the subset LLGo can observe and move coverage from the cl/_testgo golden runner to a go/llgo-compatible test/std/runtime/metrics package. Signed-off-by: ZhouGuangyuan <zhouguangyuan.xian@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtime/metrics.ReadValueKinds while returning zero defaults for unsupported valuesruntime.MemStatstest/std/runtime/metricsso bothgo testandllgo testexercise itTests
go test ./test/std/runtime/metrics -count=1go test ./internal/build -run 'TestBuildSourcePatchOverlayForGo126Payloads|TestApplySourcePatchForPkg' -count=1\n-./dev/llgo.sh test ./test/std/runtime/metrics\n-git diff --check HEAD~1..HEAD