Open
Conversation
Demonese
force-pushed
the
feature/shared-library-exports
branch
from
277b14d to
1619a82
Compare
Comment on lines
+136
to
+138
| # elif defined(__GNUC__) | ||
| # define OP_LIBRARY_API __attribute__((visibility("default"))) | ||
| # endif |
There was a problem hiding this comment.
Why is this part for GNUC needed?
Author
There was a problem hiding this comment.
Line 77 in 24d6e75
$<$<C_COMPILER_ID:Clang,GNU>:-fvisibility=hidden>Because visibility is hidden by default.
|
The set of changes look good to me. I only wonder about the need for changes when using GNUC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although libopusfile can be compiled into a shared library, it lacks symbol exports, which has troubled me for a long time.
So I write this PR.