Merge pull request #2836 from JohanMabille/apply_cv

Replaced apply_cv with xtl::apply_cv and deleted duplicated code

Author: JohanMabille

include/xtensor/utils/xutils.hpp

@@ -533,74 +533,6 @@ namespace xt
         return std::get<I>(static_cast<const std::tuple<Args...>&>(v));
     }
 
-    /***************************
-     * apply_cv implementation *
-     ***************************/
-
-    namespace detail
-    {
-        template <
-            class T,
-            class U,
-            bool = std::is_const<std::remove_reference_t<T>>::value,
-            bool = std::is_volatile<std::remove_reference_t<T>>::value>
-        struct apply_cv_impl
-        {
-            using type = U;
-        };
-
-        template <class T, class U>
-        struct apply_cv_impl<T, U, true, false>
-        {
-            using type = const U;
-        };
-
-        template <class T, class U>
-        struct apply_cv_impl<T, U, false, true>
-        {
-            using type = volatile U;
-        };
-
-        template <class T, class U>
-        struct apply_cv_impl<T, U, true, true>
-        {
-            using type = const volatile U;
-        };
-
-        template <class T, class U>
-        struct apply_cv_impl<T&, U, false, false>
-        {
-            using type = U&;
-        };
-
-        template <class T, class U>
-        struct apply_cv_impl<T&, U, true, false>
-        {
-            using type = const U&;
-        };
-
-        template <class T, class U>
-        struct apply_cv_impl<T&, U, false, true>
-        {
-            using type = volatile U&;
-        };
-
-        template <class T, class U>
-        struct apply_cv_impl<T&, U, true, true>
-        {
-            using type = const volatile U&;
-        };
-    }
-
-    template <class T, class U>
-    struct apply_cv
-    {
-        using type = typename detail::apply_cv_impl<T, U>::type;
-    };
-
-    template <class T, class U>
-    using apply_cv_t = typename apply_cv<T, U>::type;
-
     /**************************
      * to_array implementation *
      ***************************/

include/xtensor/views/xaxis_iterator.hpp

@@ -41,8 +41,8 @@ namespace xt
         using difference_type = typename xexpression_type::difference_type;
         using shape_type = typename xexpression_type::shape_type;
         using value_type = xstrided_view<CT, shape_type>;
-        using reference = std::remove_reference_t<apply_cv_t<CT, value_type>>;
-        using pointer = xtl::xclosure_pointer<std::remove_reference_t<apply_cv_t<CT, value_type>>>;
+        using reference = std::remove_reference_t<xtl::apply_cv_t<CT, value_type>>;
+        using pointer = xtl::xclosure_pointer<std::remove_reference_t<xtl::apply_cv_t<CT, value_type>>>;
 
         using iterator_category = std::forward_iterator_tag;
 

include/xtensor/views/xaxis_slice_iterator.hpp

@@ -37,8 +37,8 @@ namespace xt
         using shape_type = typename xexpression_type::shape_type;
         using strides_type = typename xexpression_type::strides_type;
         using value_type = xstrided_view<CT, shape_type>;
-        using reference = std::remove_reference_t<apply_cv_t<CT, value_type>>;
-        using pointer = xtl::xclosure_pointer<std::remove_reference_t<apply_cv_t<CT, value_type>>>;
+        using reference = std::remove_reference_t<xtl::apply_cv_t<CT, value_type>>;
+        using pointer = xtl::xclosure_pointer<std::remove_reference_t<xtl::apply_cv_t<CT, value_type>>>;
 
         using iterator_category = std::forward_iterator_tag;