Unit test itself has issue #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a length of exactly 256 should be encoded as: 0x82 0x01 0x00 without this change, I was seeing the encoded length of a get response (that happened to be exactly 256 bytes long) encoded as: 0x81 0x00 that was causing snmpbulkwalk to fail, since it was reading the encoded length as 0.
…it test cases has an issue, resulting in false negatives. This then prevents the automated workflow from succeeding. ***Temporarily*** disable the one unit test: "Should fail to parse a corrupt buffer" This test needs to be modified to ensure that it always results in the intended test outcome, perhaps by not relying on random data.
0neblock
approved these changes
Jan 15, 2026
| } | ||
|
|
||
| SECTION( "Should fail to parse a corrupt buffer "){ | ||
| /* SECTION( "Should fail to parse a corrupt buffer "){ |
Owner
There was a problem hiding this comment.
Probably the best approach for now. Thanks for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in the comments of PR 59 ( #59 ), one of the unit test cases has an issue, resulting in false negatives. This then prevents the automated workflow from succeeding.
Temporarily disable the one unit test: "Should fail to parse a corrupt buffer"
This test ultimately needs to be modified to ensure that it always results in the intended test outcome, perhaps by not relying on random data.