Open
Conversation
- Fix "compiles to Miden assembly" → compiles to .masp package file - Add note explaining felt macro vs Felt type - Fix "Miden component" → "Miden account component" - Clarify storage key strategy wording - Add trace log output and explanation to expected output - Add MidenScan link for verifying deployment Closes #218
- felt! accepts integer literals (not constants) with compile-time validation - Currently restricted to u32 range due to compiler limitation - Mention Felt::from_u64_unchecked() for larger values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.masppackage file"feltvsFeltnote explaining macro vs typeFixes #218