feat: add binary to benchmark TPS#2073
Draft
SantiagoPittella wants to merge 8 commits into
Draft
Conversation
8c02a61 to
dca1f4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially address #1989
THis PR introduces a new binary to run benchmarks against the Miden node:
miden-benchmark. It is split in two subcommands:create-proofs: which generates proofs and stores them in a file.run-benchmark: that reads the proofs file, submits them to the node and generates a report of the result.Along with the new binary, this PR also introduces a small change in the block producer configurations by
batch_workersconfigurable.Note
Currently it won't work against the deployed against the deployed networks due to a change in the protobuf definition of
SyncMmr.Note
Generating 2k transaction (1k mint 1k consume) takes a bit over an hour in a Macbook M4 Max.
In the README of the new binary I added a section about how to start up the block producer with some parameters changes to increase the limit of TPS imposed by the node:
TX PER BATCH * BATCHES PER BLOCK / INTERVAL PER BLOCK. At the moment of posting this and with the node's configuration from the README, I didn't reached the limit of TPS yet, though I never sent more than 1k transactions at a time (because the mint transaction are submitted sequentially).The next steps are to: