feat(rpc): finalize SyncChainMmr gRPC endpoint#2075
Open
kkovaacs wants to merge 3 commits into
Open
Conversation
22c2bad to
e76a4b9
Compare
Mirko-von-Leipzig
approved these changes
May 14, 2026
3e162ee to
7b6e616
Compare
bobbinth
approved these changes
May 14, 2026
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left one small comment inline.
Comment on lines
+74
to
+89
| /// ```sql | ||
| /// -- with argument | ||
| /// SELECT block_num, block_header, signature | ||
| /// FROM block_headers | ||
| /// WHERE block_num = ?1 | ||
| /// | ||
| /// -- without argument | ||
| /// SELECT block_num, block_header, signature | ||
| /// FROM block_headers | ||
| /// ORDER BY block_num DESC | ||
| /// LIMIT 1 | ||
| /// ``` | ||
| pub(crate) fn select_block_header_and_signature_by_block_num( | ||
| conn: &mut SqliteConnection, | ||
| block_number: BlockNumber, | ||
| ) -> Result<Option<(BlockHeader, Signature)>, DatabaseError> { |
Contributor
There was a problem hiding this comment.
Are the two options still relevant? Seems like we always provide block_number now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion in PR #2069 and issue #2044 we've converged on some smaller changes to the
SyncChainMmrendpoint.Changes made to the current interface:
The proposed protobuf interface (implemented by this PR) is the following:
Closes #2044