fix: await mongoose.connect to properly catch connection errors#69
Open
Olexandr88 wants to merge 1 commit into0xProject:mainfrom
Open
fix: await mongoose.connect to properly catch connection errors#69Olexandr88 wants to merge 1 commit into0xProject:mainfrom
Olexandr88 wants to merge 1 commit into0xProject:mainfrom
Conversation
Contributor
|
@Olexandr88 is attempting to deploy a commit to the 0x Eng Team on Vercel. A member of the Team first needs to authorize it. |
oconnorw225-del
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mongoose.connect() is async, so without await the try/catch block doesn't catch connection errors. This ensures the app properly handles MongoDB connection failures instead of failing silently or causing unhandled promise rejections.