Open
Conversation
Author
|
Converting to a draft. While this update adds the UI, it also seems to return the wrong posts in the relationship UI. |
gthayer
force-pushed
the
feature/multiple-posttype-ui
branch
from
9954c01 to
0eba30f
Compare
gthayer
commented
May 16, 2025
| $to = implode( '.', $to ); | ||
|
|
||
| return "{$from}_{$to}_{$name}"; | ||
| return "{$from}~{$to}~{$name}"; |
Author
There was a problem hiding this comment.
Switched to a more obscure delimiter to avoid confusion with underscores in post type names.
gthayer
commented
May 16, 2025
| return $this->post_post_relationships[ $key ]; | ||
| } | ||
|
|
||
| // Fuzzy match the relationship by parsing the key and looping through the relationships |
Author
There was a problem hiding this comment.
Truthfully, I'm not in love with the fuzzy match. I think this could break down if a post type name contained the name of another post type. ex: "post" and "postcard".
The challenge here is that the relationship name needs to be able to be constructed, however when the post type is one of the "many" set, it does not have knowledge of it's siblings and the key can not be constructed properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This update adds support for the UI metabox to display on editor screens for post_to_post connections which have a "one to many" relationship.
The plugin supports the ability to define a "one to many" relationship, however it also intentionally disables the metabox from displaying within the editor. I am unclear why this was disabled originally, but it seems the architecture does not easily support the feature because of how relationship keys are detected and constructed.
This PR removes these restrictions and adds a "fuzzy match" to try and better identify the post relationships.
Closes #103
How to test the Change
Create a "one to many" relationship using define_post_to_post. The
$tovalue should be an array of post types.Once defined, ensure:
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: