Do not compute difficulty adjustment on Testnet4#422
Merged
rustaceanrob merged 1 commit into2140-dev:masterfrom Jun 18, 2025
Merged
Do not compute difficulty adjustment on Testnet4#422rustaceanrob merged 1 commit into2140-dev:masterfrom
Testnet4#422rustaceanrob merged 1 commit into2140-dev:masterfrom
Conversation
Raised by: bitcoindevkit/bdk-cli#197 Users of `Testnet4` will run into problems when loading headers from the database, as the network allows for minimum difficulty blocks. Instead of adding logic for the header timestamps just for the sake of `Testnet4`, I am opting to simply ignore the difficutly adjustment. This boolean does not evaluate to `true` on `Bitcoin`, which is easily verified in `rust-bitcoin`. Notably `Signet` does not allow minimum difficulty blocks, so difficulty adjustment logic is still tested by a testnet as well as mainnet. This is only dropping `Testnet4`
rustaceanrob
force-pushed
the
testnet4-diff
branch
from
f46d58e to
c549387
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raised by: bitcoindevkit/bdk-cli#197
Users of
Testnet4will run into problems when loading headers from the database, as the network allows for minimum difficulty blocks. Instead of adding logic for the header timestamps just for the sake ofTestnet4, I am opting to simply ignore the difficutly adjustment. This boolean does not evaluate totrueonBitcoin, which is easily verified inrust-bitcoin.Notably
Signetdoes not allow minimum difficulty blocks, so difficulty adjustment logic is still tested by a testnet as well as mainnet. This is only droppingTestnet4