Fixes crash in iOS 13.6 iPhone 11#15
Open
gazialankus wants to merge 1 commit into24i:feature/ios-track-fullscreen-controlsfrom
Open
Fixes crash in iOS 13.6 iPhone 11#15gazialankus wants to merge 1 commit into24i:feature/ios-track-fullscreen-controlsfrom
gazialankus wants to merge 1 commit into24i:feature/ios-track-fullscreen-controlsfrom
Conversation
alexejh
pushed a commit
to simpleTechs/react-native-video
that referenced
this pull request
Jul 29, 2022
This PR is intended to prevent memory crashes when the free memory runs out Jira: VEX-6030 https://jira.tenkasu.net/browse/VEX-6030 Velocity PR: crunchyroll/velocity#2043 By forcefully calling the garbage collector the memory crashes, specially on lower resolutions (<720p) are gone on devices with 2GB of ram or less and Android 6, also testing 3GB Android 7 with this patch, so far is working as intended Reviews Major reviewer (domain expert): @nickfujita Minor reviewer: @jctorresM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the crash that happens in iPhone11 (iOS 13.6), tested in iOS Simulator.
When you go to fullscreen, video freezes after a bit. Trying to exit fullscreen crashes with an error. This fixes it.
Also tested in iPhone 6 and iPhone 7 (iOS 12.4) in Simulator, works fine there as well.