Fix error when close launched application new approach#107
Open
quangnt wants to merge 3 commits into2gis:masterfrom
Open
Fix error when close launched application new approach#107quangnt wants to merge 3 commits into2gis:masterfrom
quangnt wants to merge 3 commits into2gis:masterfrom
Conversation
with a launcher. That can fix exception Process Not Found in close/quit function. * Fix error when get some attributes.
quangnt
force-pushed
the
fix-error-when-close-launched-application
branch
4 times, most recently
from
ef8b13b to
ff484ed
Compare
quangnt
force-pushed
the
fix-error-when-close-launched-application
branch
from
516ea8d to
4ab296d
Compare
skyline-gleb
requested changes
Sep 20, 2016
Contributor
skyline-gleb
left a comment
skyline-gleb
left a comment
There was a problem hiding this comment.
@quangnt Hi, looks great, could you please remove changes in CHANGELOG.md (changes automatically at release)
Contributor
|
@NickAb join us to review, please |
NickAb
reviewed
Sep 20, 2016
| var intArray = obj as Int32[]; | ||
| if (intArray != null) | ||
| { | ||
| return string.Join(",", intArray); |
Contributor
There was a problem hiding this comment.
Why do integer arrays need special serialization? By default the should be serialized as json object like other arrays, dictionaries, etc.
Author
There was a problem hiding this comment.
Last time, I had problem when get specific property of GUI element which returns array of integers (not remember exactly its type, System.Int32[] or System.Int64[]) and throws exception that type of object is not serialized object. So I force it as Int32[] and put result as string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.