Skip to content

🦋 Update Product overview#4259

Open
josemigallas wants to merge 3 commits intomasterfrom
THREESCALE-14090_product_overview
Open

🦋 Update Product overview#4259
josemigallas wants to merge 3 commits intomasterfrom
THREESCALE-14090_product_overview

Conversation

@josemigallas
Copy link
Copy Markdown
Contributor

@josemigallas josemigallas commented Mar 26, 2026

THREESCALE-14090: Product overview page

Replace old left/right and other legacy styles with PF4. Refactor the show template and move presentational stuff into Service decorator.

Before:

Screenshot 2026-03-31 at 12-49-05 Services - Show Red Hat 3scale API Management Screenshot 2026-03-31 at 12-47-09 Services - Show Red Hat 3scale API Management Screenshot 2026-03-31 at 12-46-44 Services - Show Red Hat 3scale API Management

After:

Screenshot 2026-03-31 at 12-46-12 Services - Show Red Hat 3scale API Management Screenshot 2026-03-31 at 12-44-33 Services - Show Red Hat 3scale API Management Screenshot 2026-03-31 at 12-40-56 Services - Show Red Hat 3scale API Management

@josemigallas josemigallas requested a review from a team March 26, 2026 14:33
@josemigallas josemigallas self-assigned this Mar 26, 2026
@qltysh
Copy link
Copy Markdown

qltysh bot commented Mar 26, 2026

❌ 12 blocking issues (13 total)

Tool Category Rule Count
eslint Lint Unsafe return of an any typed value. 3
eslint Lint Unsafe assignment of an any value. 3
reek Lint ServiceDecorator#friendly_service_settings refers to 'value' more than self (maybe move it to another class?) 2
eslint Lint Variable name ProductsUsedListCard must match one of the following formats: camelCase, UPPER_CASE 2
rubocop Performance Use filter\_map instead. 1
rubocop Lint Prefer assert\_not over refute. 1
qlty Structure Function with high complexity (count = 9): friendly_service_settings 1

@josemigallas josemigallas marked this pull request as draft March 26, 2026 14:45
@josemigallas josemigallas force-pushed the THREESCALE-14090_product_overview branch from 0e6492e to b4b37d3 Compare March 31, 2026 10:29
@josemigallas josemigallas marked this pull request as ready for review March 31, 2026 10:50
@josemigallas josemigallas changed the title 🦋 updates Product overview with PF4 and remove legacy styles 🦋 Update Product overview Mar 31, 2026
Comment thread app/javascript/src/Common/components/CompactListCard.tsx Outdated
Comment thread app/decorators/service_decorator.rb Outdated
Comment thread app/decorators/service_decorator.rb Outdated
Comment thread app/decorators/service_decorator.rb Outdated
Comment thread test/factories/alert.rb Outdated
Comment thread .rubocop.yml Outdated
Comment thread app/views/api/services/cards/_service_plans.html.slim Outdated
@josemigallas
Copy link
Copy Markdown
Contributor Author

UPDATE: changed term "contract" for "subscription" for consistency with /buyers/service_contracts page:
Screenshot 2026-04-08 at 11 43 09

Screenshot 2026-04-08 at 11 41 12

@josemigallas josemigallas requested a review from jlledom April 8, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants