THREESCALE-14262 - deploy runs seed on empty database#4265
Merged
akostadinov merged 1 commit into3scale:masterfrom Apr 9, 2026
Merged
THREESCALE-14262 - deploy runs seed on empty database#4265akostadinov merged 1 commit into3scale:masterfrom
akostadinov merged 1 commit into3scale:masterfrom
Conversation
jlledom
approved these changes
Apr 7, 2026
Contributor
jlledom
left a comment
jlledom
left a comment
There was a problem hiding this comment.
Haven't tested. But I trust you
|
I have tested with configuration where master password was set to invalid value and the seed was failing, but a re-run of the deploy task simply passed without an issue: Run 1: Run 2: What I expected was the run 2 to re-try the migration and keep failing until I fix the password. |
Contributor
Author
|
@urbanikb I will try to replicate locally exactly what you have done to replicate because simulated failure locally showed me the correct result. Could you just positively check you are running the correct image :) |
Thanks for the prompt - the image that ran was indeed |
|
False alarm - the test with the actual image works as expected, subsequent runs error out. Run 1 Run 2+ |
urbanikb
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If seeding fails for example because seed password was weak, then currently for a customer it would be a mess to recover from this situation. They will need to clear the database completely.
Not we detect empty database and run the seed on startup.
My tests show that original behavior doesn't change.
I notice a problem though, the code reads to me as if it should work even if the database (not the server, just the database) is not created yet and will try to create. But on postgres at least, if database doesn't exist,
db:deployfails. This is no change from current behavior though so I'm leaving it for another life.