Skip to content

Conversation

@austin-bingham-4ss
Copy link
Collaborator

@austin-bingham-4ss austin-bingham-4ss commented Jul 2, 2025

Description

Fix a few invalid escape sequences that were printing warnings during import.

This was happening because of changes in Python 3.12. https://docs.python.org/3/whatsnew/3.12.html#other-language-changes

@austin-bingham-4ss austin-bingham-4ss requested review from ali-cetin-4ss and wojciech-bochniarz-4ss and removed request for ali-cetin-4ss July 2, 2025 10:02
@wojciech-bochniarz-4ss
Copy link
Contributor

There are failing tests that need to be fixed before we can merge this change

@austin-bingham-4ss
Copy link
Collaborator Author

Do you see any way in which my change is causing the test failures?

@austin-bingham-4ss
Copy link
Collaborator Author

FWIW, I see the same failure when I run the tests locally, both for my branch and for master. It looks like some authentication endpoint has changed or something. In any event, unless there's some indication that my change has something to do with that, I don't know what to do.

@wojciech-bochniarz-4ss
Copy link
Contributor

Im looking into it and it seems that those test break when running in isolated environment, I will try to fix this issue and let you know when its done

@wojciech-bochniarz-4ss
Copy link
Contributor

@austin-bingham-4ss You can merge changes from master that will fix tests. There were some problems after pytest upgraded its package and it broke some tests

@austin-bingham-4ss austin-bingham-4ss force-pushed the fixed-invalid-escape-sequences branch from 7a5036a to b73c5af Compare July 14, 2025 06:01
@wojciech-bochniarz-4ss wojciech-bochniarz-4ss added the refactor Changes to the code label Jul 14, 2025
@austin-bingham-4ss
Copy link
Collaborator Author

@wojciech-bochniarz-4ss I'm not authorized to merge the PR (and don't want to be), so feel free to merge this in if it's ready.

@wojciech-bochniarz-4ss wojciech-bochniarz-4ss merged commit 3d739b1 into master Jul 14, 2025
9 checks passed
@wojciech-bochniarz-4ss wojciech-bochniarz-4ss deleted the fixed-invalid-escape-sequences branch July 14, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Changes to the code

Development

Successfully merging this pull request may close these issues.

3 participants