Skip to content

Fix dirm degrees default and wrong scaling when .reshape is called #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vegard-solum-4ss merged 5 commits into from
Jun 23, 2025
Merged

Fix dirm degrees default and wrong scaling when .reshape is called #85

vegard-solum-4ss merged 5 commits into from
Jun 23, 2025

Conversation

@ali-cetin-4ss
Copy link
Member

@ali-cetin-4ss ali-cetin-4ss commented Jun 23, 2025 •
edited
Loading

This PR is related to user story ESS-XXXX

Description

Performed unnecessary and wrong scaling to internal representation of values when .reshape is called.

Checklist

  • PR title is descriptive and fit for injection into release notes (see tips below)
  • Correct label(s) are used

PR title tips:

  • Use imperative mood
  • Describe the motivation for change, issue that has been solved or what has been improved - not how
  • Examples:
    • Add functionality for Allan variance to sensor_4s.simulate
    • Upgrade to support Python 9.10
    • Remove MacOS from CI

@ali-cetin-4ss ali-cetin-4ss added the bug Bug fixes label Jun 23, 2025
@ali-cetin-4ss ali-cetin-4ss mentioned this pull request Jun 23, 2025
Closed
2 tasks
@ali-cetin-4ss ali-cetin-4ss changed the title Fix wrong scaling when .reshape is called Fix dirm degrees default and wrong scaling when .reshape is called Jun 23, 2025
@vegard-solum-4ss vegard-solum-4ss merged commit 7bab614 into main Jun 23, 2025
6 checks passed
@vegard-solum-4ss vegard-solum-4ss deleted the fix-reshape branch June 23, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vegard-solum-4ss vegard-solum-4ss vegard-solum-4ss approved these changes

Assignees

No one assigned

Labels

bug Bug fixes

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ali-cetin-4ss @vegard-solum-4ss