Open
Conversation
Owner
4s-ary
commented
Oct 23, 2021
4s-ary
commented
Open
| @@ -0,0 +1,23 @@ | |||
| import { FC } from "react"; | |||
Collaborator
There was a problem hiding this comment.
Путь должен быть assets/icons
| ) | ||
| const InteractionArea: FC<Props> = ({inputValue, handleInputCallBack, addButton, addButtonText}) => { | ||
| const handleTodoAddingOnKeyDown = (event: KeyboardEvent) => { | ||
| if (event.code === "Enter") { |
Collaborator
There was a problem hiding this comment.
Должен предусмотреть все enter на клавиатуре
| } | ||
| }; | ||
| return ( | ||
| <div className={styles.Container}> |
Collaborator
There was a problem hiding this comment.
стили с маленькой буквы styles.container
| justify-content: center; | ||
| width: 40%; | ||
| margin: 0 auto; | ||
| height: fit-content; |
| return ( | ||
| <div key={id} className={styles.listElement}> | ||
| {title} | ||
| <div className={styles.deleteItem} id={`${id}`} onClick={deleteListElementCallBack}> |
Collaborator
There was a problem hiding this comment.
Сделай так - onClick={() => deleteListElementCallBack(id)}
|
|
||
| } | ||
|
|
||
| const Search: FC<SearchProps> = ({showSearchBox}) => { |
Collaborator
There was a problem hiding this comment.
Условный рендер должен быть сверху, а не внутри компонента
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.