Replace Thor CLI with optparse to align with Crystal CLI#18
Merged
antondalgren merged 1 commit intomainfrom Mar 10, 2026
Merged
Replace Thor CLI with optparse to align with Crystal CLI#18antondalgren merged 1 commit intomainfrom
antondalgren merged 1 commit intomainfrom
Conversation
Use stdlib optparse instead of Thor, matching the Crystal client's CLI interface. Subcommands are now `send` (was `auth`) and `connect`, with flag-based options (-h, -p, -c) instead of positional args. Connect reuses send's option parser and adds --tcp-port. Drops the thor dependency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
baelter
approved these changes
Mar 10, 2026
Member
baelter
left a comment
baelter
left a comment
There was a problem hiding this comment.
I approve, would also approve removing it :)
walro
reviewed
Mar 10, 2026
walro
reviewed
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
To align CLI interface.
WHAT is this pull request doing?
Use stdlib optparse instead of Thor, matching the Crystal client's CLI interface. Subcommands are now
send(wasauth) andconnect, with flag-based options (-h, -p, -c) instead of positional args. Connect reuses send's option parser and adds --tcp-port. Drops the thor dependency.HOW was this pull request tested?
Specs? Manual steps? Please fill me in.