Poll for server availability in suite setup#60
Open
eatoncns wants to merge 3 commits into
Open
Conversation
The aim here is to aid polling of availability of server during server start up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the test suite setup runs server start command and then sleeps for 2 seconds. This sleep time is a bit arbitrary and can cause test instability for servers with longer start up times.
Code change polls server socket to check availability before starting tests.
N.b. The exception handling is a bit ugly as it seems that we are using java version that doesn't support try-with-resources . I'm not super familiar with Java so would be happy to get feedback on any better way of doing this.