Instructions for integrating CI with cob spec#68
Conversation
ericmeyer
left a comment
ericmeyer
left a comment
There was a problem hiding this comment.
This is a really great addition to the repo. Thanks for taking the initiative to update the README.
A couple high level comments:
- This could probably be squashed into a single commit.
- Did you consider adding example files for both the cob spec test runner and/or the
travis.ymlfile to the repo and referencing those from the README? That might be overkill.
On a side note, I would encourage you to spend more time on both your Git commit messages. "formatting" is very generic, and does not really tell me what the commit is doing.
| ------------ | ||
| - Fork cob spec | ||
| - On your local machine navigate to your server's directory | ||
| - Create a submodule using the forked copy of cob spec `git submodule add https://github.com/myusername/cob_spec` |
There was a problem hiding this comment.
Should this be the SSH version of the URL in case someone wants to push changes to their fork?
| - Within this new submodule navigate to `FitNesseRoot` and create a new directory `mkdir PassingTests` | ||
| - Copy contents of `HttpTestSuite` into your new directory `PassingTests` by issuing the following command: `cp -r HttpTestSuite/ PassingTests/` | ||
| - Navigate into `PassingTests/ResponseTestSuite` and add/remove cob spec tests as necessary | ||
| - To add a test to the `PassingTests`: `cp -r HttpTestSuite/ResponseTestSuite/SimpleGet PassingTests/ResponseTestSuite/SimpleGet/` |
There was a problem hiding this comment.
I was under the impression that there is a way to include a test in a different suite without having to duplicate it. Possibly by using something like Fitnesse's Include feature
There's a chance I am wrong about this though.
| `java -jar fitnesse.jar -c "PassingTests?suite&format=test"` | ||
|
|
||
| - The following CI instructions are for TravisCI but follow a similar pattern for other CI platforms. In .travis.yml: | ||
| `before_install:` |
There was a problem hiding this comment.
See above comment about merging the lines into one.
| - Navigate to your server's directory. Create a new `.sh` file `touch run_cob_spec_tests.sh` | ||
| - Open the file and add the following: | ||
|
|
||
| `#!/bin/bash` |
There was a problem hiding this comment.
To me, this feels like it could be one code block, especially since the lines are logically grouped with each other.
Like this:
```bash
#!/bin/bash
set -e
mvn package
...
```
2 participants
No description provided.