Conversation
…CCESS-ESM1.6 mappings
…ion and update calculation type in ACCESS-ESM1.6 mappings
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
- Coverage 62.24% 61.06% -1.18%
==========================================
Files 19 19
Lines 2961 3054 +93
==========================================
+ Hits 1843 1865 +22
- Misses 1118 1189 +71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…CCESS-ESM1.6_mappings.json, and vocabulary_processors.py for improved readability
…ca.pa-298810_mon.nc in multiple test modules
| @pytest.mark.integration | ||
| @pytest.mark.skipif( | ||
| not (DATA_DIR / "esm1-6/atmosphere/aiihca.pa-101909_mon.nc").exists(), | ||
| not (DATA_DIR / "esm1-6/atmosphere/aiihca.pa-298810_mon.nc").exists(), |
There was a problem hiding this comment.
Those data hasn't been upload yet with this branch.
There was a problem hiding this comment.
Review: Integration Test Failures
Thanks for adding comprehensive integration tests! The test infrastructure looks solid, but I've identified two critical issues that need to be addressed before this can be merged.
Issue 1: Coordinate Renaming Conflict (huss variable)
Location: atmosphere.py → select_and_process_variables()
Error:
ValueError: the new name 'lat' conflictsRoot Cause:
The dataset contains both lat (145 points) and lat_v (144 points) as separate variables. When the code attempts to rename lat_v → lat, it creates a naming conflict because lat already exists.
Impact: Affects all variables that use staggered grids (V-grid for atmosphere).
Alternatively, we might need to select the appropriate coordinate based on the variable's grid (U-grid vs V-grid) before attempting the rename.
Issue 2: Missing Required Variable (mrso calculation)
Location: derivations/__init__.py → evaluate_expression()
Error:
KeyError: 'depth'Root Cause:
The calculation for mrso (total soil moisture content) references a depth variable that doesn't exist in the input dataset. The dataset contains soil_model_level_number but not the actual depth values in meters.
Impact: Affects all land variables requiring soil depth information.
Context from logs:
fld_s08i223: data variable → time:1, soil_model_level_number:6, lat:145, lon:192
Might be some issue with the mapping, I will look into those
|
I think the mapping for huss and hus was wrong...I fixed it |
…t of water in soil
|
I have fixed huss and mrso. |
work in progress