Merged
Conversation
In #1320 some of the tests failed due to differences in precision. We have seen this before in other places. The log messages included... ``` I0000 00:00:1774527545.928435 2907 port.cc:153] oneDNN custom operations are on. You may see slightly different numerical results due to floating-point round-off errors from different computation orders. To turn them off, set the environment variable `TF_ENABLE_ONEDNN_OPTS=0`. I0000 00:00:1774527545.929005 2907 cudart_stub.cc:31] Could not find cuda drivers on your machine, GPU will not be used. ``` This commit/pull-request therefore sets `TF_ENABLE_ONEDNN_OPTS` to `0` as suggested.
Collaborator
Author
|
Re-running tests and they pass, failures noted in #1322 for future investigation/fixing. |
SylviaWhittle
approved these changes
Apr 7, 2026
Collaborator
SylviaWhittle
left a comment
SylviaWhittle
left a comment
There was a problem hiding this comment.
Yep. Fixes the tests. Sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1320 some of the tests failed due to differences in precision.
We have seen this before in other places.
The log messages included...
This commit/pull-request therefore sets
TF_ENABLE_ONEDNN_OPTSto0as suggested.All tests pass locally (Python 3.11.14; tensorflow-2.18.0) will test against tensorflow-2.21.0 but have to wait for the
0.5GB download.
Before submitting a Pull Request please check the following.