add mutable_type typedef to collection and user collection#718
Merged
tmadlener merged 3 commits intoAIDASoft:masterfrom Dec 19, 2024
Merged
add mutable_type typedef to collection and user collection#718tmadlener merged 3 commits intoAIDASoft:masterfrom
mutable_type typedef to collection and user collection#718tmadlener merged 3 commits intoAIDASoft:masterfrom
Conversation
tmadlener
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
mutable_typetypedef to collection to simplify inferring mutable type. Addmutable_typetypedef to user collection for compatibility with other collections.ENDRELEASENOTES
As suggested in #626 (comment) some code can be simplify if had a typedef for mutable type instead of going through patter like
collection::value_type::mutable_typemutable_typeis already present in link collection. I propose to add it to user data collection so all the collections offer similar API even if in that case it's redundant