Code Hygiene #137
Closed
Code Hygiene #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: .github/workflows/create-dependabot-labels.yaml
new file: src/main/java/frc/robot/subsystems/vision/FRC254/RobotState.java new file: src/main/java/frc/robot/subsystems/vision/FRC254/VisionFieldPoseEstimate.java new file: src/main/java/frc/robot/subsystems/vision/FRC254/VisionSubsystem.java new file: src/main/java/frc/robot/subsystems/vision/FRC6328/RobotState.java new file: src/main/java/frc/robot/subsystems/vision/FRC6328/Vision.java new file: src/main/java/frc/robot/subsystems/vision/FRC6328/VisionConstants.java
modified: src/main/java/frc/robot/Constants.java new file: src/main/java/frc/robot/subsystems/vision/FRC254/FiducialObservation.java new file: src/main/java/frc/robot/subsystems/vision/FRC254/MegatagPoseEstimate.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/RobotState.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/VisionFieldPoseEstimate.java new file: src/main/java/frc/robot/subsystems/vision/FRC254/VisionIO.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/VisionSubsystem.java modified: src/main/java/frc/robot/subsystems/vision/Vision.java modified: src/main/java/frc/robot/subsystems/vision/VisionIOPhotonVision.java modified: src/main/java/frc/robot/subsystems/vision/VisionIOPhotonVisionSim.java new file: src/main/java/frc/robot/util/ConcurrentTimeInterpolatableBuffer.java new file: src/main/java/frc/robot/util/LimelightHelpers.java new file: src/main/java/frc/robot/util/MathHelpers.java new file: src/main/java/frc/robot/util/RobotTime.java new file: src/main/java/frc/robot/util/Util.java
Next step is to mesh in the parts of the vision code I need for the circular vision buffer to the base vision subsystem. new file: src/main/java/frc/robot/subsystems/vision/FRC254/Constants.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/FiducialObservation.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/MegatagPoseEstimate.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/RobotState.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/VisionSubsystem.java new file: src/main/java/frc/robot/util/ServoMotorSubsystemConfig.java
new file: src/main/java/frc/robot/subsystems/vision/FRC180/CoralDetector.java new file: src/main/java/frc/robot/subsystems/vision/FRC180/CoralDetectorReal.java new file: src/main/java/frc/robot/subsystems/vision/FRC180/CoralDetectorSim.java new file: src/main/java/frc/robot/subsystems/vision/FRC180/Field.java new file: src/main/java/frc/robot/subsystems/vision/FRC180/LEDSubsystem.java new file: src/main/java/frc/robot/subsystems/vision/FRC180/ReefProximity.java new file: src/main/java/frc/robot/subsystems/vision/FRC180/VisionIO.java new file: src/main/java/frc/robot/subsystems/vision/FRC180/VisionIOLimelight.java new file: src/main/java/frc/robot/subsystems/vision/FRC180/VisionIOPhoton.java new file: src/main/java/frc/robot/subsystems/vision/FRC180/VisionSubsystem.java new file: src/main/java/frc/robot/subsystems/vision/FRC6995/Vision.java new file: src/main/java/frc/robot/util/TriConsumer.java
The vision subsystem from FRC180 / SPAM now builds within the 2486 code base. Next steps are to figure out which parts of the various vision combination schemes I want to use and hack together something! modified: src/main/java/frc/robot/Constants.java modified: src/main/java/frc/robot/Robot.java modified: src/main/java/frc/robot/RobotContainer.java modified: src/main/java/frc/robot/subsystems/drive/Drive.java new file: src/main/java/frc/robot/subsystems/vision/FRC180/CameraStatus.java modified: src/main/java/frc/robot/subsystems/vision/FRC180/CoralDetectorSim.java modified: src/main/java/frc/robot/subsystems/vision/FRC180/Field.java modified: src/main/java/frc/robot/subsystems/vision/FRC180/LEDSubsystem.java new file: src/main/java/frc/robot/subsystems/vision/FRC180/LimelightStatus.java new file: src/main/java/frc/robot/subsystems/vision/FRC180/SimCamera.java new file: src/main/java/frc/robot/subsystems/vision/FRC180/SimLogic.java modified: src/main/java/frc/robot/subsystems/vision/FRC180/VisionIOLimelight.java modified: src/main/java/frc/robot/subsystems/vision/FRC180/VisionIOPhoton.java modified: src/main/java/frc/robot/subsystems/vision/FRC180/VisionSubsystem.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/Constants.java modified: src/main/java/frc/robot/util/LimelightHelpers.java
modified: src/main/java/frc/robot/Constants.java new file: src/main/java/frc/robot/commands/DriveToPose.java new file: src/main/java/frc/robot/commands/DriveToPoseFast.java
modified: src/main/java/frc/robot/Constants.java modified: src/main/java/frc/robot/RobotContainer.java
modified: src/main/java/frc/robot/subsystems/vision/FRC254/Constants.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/FiducialObservation.java new file: src/main/java/frc/robot/subsystems/vision/FRC254/LedState.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/MegatagPoseEstimate.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/RobotState.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/VisionFieldPoseEstimate.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/VisionIO.java modified: src/main/java/frc/robot/subsystems/vision/FRC254/VisionSubsystem.java modified: src/main/java/frc/robot/subsystems/vision/Vision.java new file: src/main/java/frc/robot/util/FieldConstants.java
modified: .github/workflows/create-dependabot-labels.yaml
Create a pose buffer and use timestamps to match vision values with those from odometry to reduce jitter. Also be able to define certain tags in whose location we trust more (e.g. HUB in 2026) in the event of field misshappenness. Weave the new Vision structure together with the drivetrain to allow for timestamped pose insertion into the estimator.
Clean up the code, but also specifically allow the RIO or IMU to be "on its side" (i.e., Z is not necessarily "up").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly cleaning up comments and re-arranging functions to make the code more readable for users.