Skip to content

[cuebot/pycue/cuegui] Refactor VirtualProc creation#2286

Draft
DiegoTavares wants to merge 3 commits into
AcademySoftwareFoundation:masterfrom
DiegoTavares:stranded_review
Draft

[cuebot/pycue/cuegui] Refactor VirtualProc creation#2286
DiegoTavares wants to merge 3 commits into
AcademySoftwareFoundation:masterfrom
DiegoTavares:stranded_review

Conversation

@DiegoTavares
Copy link
Copy Markdown
Collaborator

Summarize your change.

Allow customizing core allocation via service. The current logic only allows setting up services to be selfish (take the entire host) and it requires changing the general opencue.properties to configure such services.

The proposed solution adds new fields to the service table to allow toggling multiple booking features:

  • Selfish Service: When on, the service takes over all available cores on a host when booked
  • Memory Free: When on, the service will not be affected by the memory stranded core balancing (See 9de7430 for docs)

Clean up core reservation logic. There's still some room for improvement, but given that the service
processing portions is intended to change on the following commit (still on this PR), it makes sense
to stop here.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8d19903a-f413-4acd-8d00-c7d0c07abb73

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DiegoTavares DiegoTavares changed the title [cuebot/pycue/cuegui] Rething VirtualProc core reservation to be Service aware [cuebot/pycue/cuegui] Refactor VirtualProc creation May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant