int: No longer force disabling of fmt exceptions#5118
Open
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
int: No longer force disabling of fmt exceptions#5118lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
I think forcing fmt to disable exceptions is probably doing more harm than good, probably does not work as expected for apps that use fmt elsewhere (when we first started using fmt, it was not super popular, so we weren't really concerned about how we might conflict with other libraries in the same app), and disabling exceptions makes it behave differently than std::format/print. So let's stop doing this and see what happens! (In main.) Also, declutter by removing the FMT_USE_GRISU definition, which was only meaningful for very old fmt versions that are oldest than our minimum supported version now. Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think forcing fmt to disable exceptions is probably doing more harm than good, probably does not work as expected for apps that use fmt elsewhere (when we first started using fmt, it was not super popular, so we weren't really concerned about how we might conflict with other libraries in the same app), and disabling exceptions makes it behave differently than std::format/print.
So let's stop doing this and see what happens! (In main.)
Also, declutter by removing the FMT_USE_GRISU definition, which was only meaningful for very old fmt versions that are older than our minimum supported version now.