build: Add a python script to test imports during the build#1057
build: Add a python script to test imports during the build#1057cedrik-fuoco-adsk wants to merge 21 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
rogernelson
left a comment
There was a problem hiding this comment.
This is great, thank you!
bernie-laberge
left a comment
There was a problem hiding this comment.
Excellent initiative !
Thanks!
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
3df383a to
fbb62e4
Compare
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
83d2766 to
c2c183f
Compare
|
Address the PR comments, but I am stil having issues with OTIO and Windows in debug. The first issue was avec the debug postfix of OTIO. OTIO uses "d" but python expects "_d". (See AcademySoftwareFoundation/OpenTimelineIO#1173). For now, I fixed (I think) that by manually renaming the files in the python script. But now I'm having this issue: |
0ab8ba1 to
ee3cfa8
Compare
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
ee3cfa8 to
c3029c5
Compare
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
|
Sorry for the bunch of commits since a couple days. It should be all good to review now. @eloisebrosseau @bernie-laberge @rogernelson |
|
Before merging this PR, I will wait a bit more time for AcademySoftwareFoundation/OpenTimelineIO#1991 to be merged in OTIO. I might merged it sooner if it's taking more time than expected. |
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Add a python script to test imports during the build
Linked issues
n/a
Summarize your change.
Add build-time validation of Python package imports and clarify Python test purposes.
Describe the reason for the change.
When there are issues with package imports (ABI incompatibilities, missing dependencies, etc.), we often find them out at runtime. This change adds
test_python_imports.pyto detect import failures during the build.Additionally, renamed
test_python.pytotest_python_distribution.pyto better distinguish between:Describe what you have tested and on which operating system.
MacOS
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.