Skip to content

fix: SG-35309: Remove OCIO output when set to active with env variable unset #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deltag0 wants to merge 6 commits into
base: main
Choose a base branch
from
+9 −1
Open

fix: SG-35309: Remove OCIO output when set to active with env variable unset #1263

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c0aab09
remove logs
deltag0 May 7, 2026
77ffaa4
remove log output for any OCIO active display with no env variable
deltag0 May 7, 2026
f175370
use specified config instead of silent failure
deltag0 May 12, 2026
8887a79
format fix
deltag0 May 12, 2026
d77d078
save OCIO in settings
deltag0 May 12, 2026
4f42ab7
format fix
deltag0 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/plugins/rv-packages/ocio_source_setup/ocio_source_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,10 @@ def selectConfig(self, event):
try:
config = commands.openFileDialog(True, False, False, "ocio|OCIO Config", None)[0]
self.config = OCIO.Config.CreateFromFile(config)
os.environ["OCIO"] = config
OCIO.SetCurrentConfig(self.config)
commands.defineModeMenu("OCIO Source Setup", self.buildOCIOMenu(), True)
commands.writeSettings("ocio_source_setup", "ocio_config", config)
except Exception as inst:
print(inst)

Expand Down Expand Up @@ -668,7 +670,8 @@ def addMenu(root, isSingle):
)
)

final = [
final = [("Change Config...", self.selectConfig, None, None)]
final += [
("Current Source", None, None, lambda: commands.DisabledMenuState),
(" File Color Space", cssList),
]
Expand Down Expand Up @@ -716,6 +719,11 @@ def __init__(self):
except ImportError:
pass

if os.getenv("OCIO") is None:
config = commands.readSettings("ocio_source_setup", "ocio_config", "")
if config != "":
os.environ["OCIO"] = config

self.init(
"OCIO Source Setup",
None,
Expand Down