Run tests on wheels#1977
Open
reinecke wants to merge 22 commits intoAcademySoftwareFoundation:mainfrom
Open
Conversation
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
ac4cb5f to
39742e7
Compare
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1977 +/- ##
==========================================
+ Coverage 85.13% 85.15% +0.01%
==========================================
Files 181 181
Lines 12783 12783
Branches 1206 1206
==========================================
+ Hits 10883 10885 +2
+ Misses 1717 1715 -2
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
… distro (mingw) Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
…ist resolution, made wheels no longer depend on smoketest Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
2293046 to
f323137
Compare
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
…ing in mingw build Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
ec030a9 to
742dc6c
Compare
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
…act is available for install and the repo is subsequently used for testing Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Collaborator
Author
|
I'm ready for feedback on this - just the one open questions about whether or not we really need the smoketests or if I should move the coverage reports to the tests we run on the equivalent wheel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change re-shuffles the CI so that:
Ideally this would take the suggestion from @JeanChristopheMorinPerso and run againstsdist- that change hasn't been made.Update: after investigation, cibuildwheel isn't really meant to happen from sdist sources. I did a pass to make our build and test only phase run off it though - since those platforms would be running off sdist in the wild.
Additionally, if we could capture coverage from one of the cibuildwheel runs, we could probably eliminate the smoke test phase.
Consider dropping the smoke test and just harvest coverage from testing the wheelsFixes #1027
This supersedes #1961 - the changes have been added to this PR