feat: add ShotGrid user authentication with session tokens#96
Draft
aviralgarg05 wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Draft
feat: add ShotGrid user authentication with session tokens#96aviralgarg05 wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
aviralgarg05 wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
Implements GitHub issue AcademySoftwareFoundation#46. Adds username/password login flow that authenticates against ShotGrid using authenticate_human_user, retrieves a session token via get_session_token, and returns it to the frontend. Backend: - Add authenticate_user to ProdtrackProviderBase and ShotgridProvider - Add LoginRequest/LoginResponse models and POST /auth/login endpoint - Add 11 new tests covering auth endpoint and provider method Frontend: - Add LoginParams/LoginResponse interfaces and ApiHandler.login() - Convert ProjectSelector from email-only to username/password login - Store session token in localStorage, pass as Bearer token with requests Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>
Collaborator
|
Hey @aviralgarg05 appologies for not commenting on the issue! I have not been able to keep up with the velocity of changes! Currently there is a PR I am wrapping up for adding deployment and google auth. As part of this, I added an Authentication provider. Once that is merged, the auth landscape is going to change in the repo. I am going to ask that we put this PR on hold then adapt it after that PR is in so that all the auth handling uses the same pattern. |
Author
|
@jspada200 I will convert it into a draft then, and wait for your changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements GitHub issue #46. Adds username/password login flow that authenticates against ShotGrid using authenticate_human_user, retrieves a session token via get_session_token, and returns it to the frontend.
Backend:
Frontend: